Skip to content

Workaround for compilation failure on MSVC #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ednolan merged 1 commit into from
Nov 14, 2024
Merged

Workaround for compilation failure on MSVC #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions include/beman/iterator_interface/iterator_interface.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,21 +142,17 @@ struct iter_cat<IteratorConcept, ReferenceType, false> {};

template <typename IteratorConcept, typename ReferenceType>
struct iter_cat<IteratorConcept, ReferenceType, true> {
private:
static constexpr auto compute_category_tag() {
if constexpr (!std::is_reference_v<ReferenceType>) {
return std::input_iterator_tag{};
} else if constexpr (std::is_base_of_v<std::random_access_iterator_tag, IteratorConcept>) {
return std::random_access_iterator_tag{};
} else if constexpr (std::is_base_of_v<std::bidirectional_iterator_tag, IteratorConcept>) {
return std::bidirectional_iterator_tag{};
} else {
return std::forward_iterator_tag{};
}
}

public:
using iterator_category = std::invoke_result_t<decltype(compute_category_tag)>;
using iterator_category =
std::conditional_t<
!std::is_reference_v<ReferenceType>,
std::input_iterator_tag,
std::conditional_t<
std::is_base_of_v<std::random_access_iterator_tag, IteratorConcept>,
std::random_access_iterator_tag,
std::conditional_t<
std::is_base_of_v<std::bidirectional_iterator_tag, IteratorConcept>,
std::bidirectional_iterator_tag,
std::forward_iterator_tag>>>;
};

} // namespace detail
Expand Down
Loading