More coverage #125
Merged
More coverage #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage was constexpr only. Improve report.
Delegating constructor still becomes inlined, unfortunately.
Delegating constructor gets inlined so coverage is still wrong.
Cover the empty branch
Coverage testing operator=(const optional<U>& rhs)
Coverage says not covered.
Code spell lint fix
```txt /usr/bin/ld: lib/Gcov/libgtest.a(gtest-all.cc.o): in function `std::nextafter(_Float16, _Float16)': /usr/include/c++/14/cmath:2877:(.text._ZSt9nextafterDF16_DF16_[_ZSt9nextafterDF16_DF16_]+0x6a): undefined reference to `nextafterf16' /usr/bin/ld: lib/Gcov/libgtest.a(gtest-all.cc.o): in function `std::nextafter(std::bfloat16_t, std::bfloat16_t)': /usr/include/c++/14/cmath:3595:(.text._ZSt9nextafterDF16bDF16b[_ZSt9nextafterDF16bDF16b]+0x6a): undefined reference to `__builtin_nextafterf16b' ``` Bug reports suggest libc vs libstdc++ issues around optimization and inlining. Allowing more inlining in gcov profile.
-fkeep-inline-functions seems to involved with failures on Ubuntu 24.04 and GCC14 with an inline definition unavailable at link time. This is causing CI errors.
Pull Request Test Coverage Report for Build 15365667797Details
💛 - Coveralls |
neatudarius
approved these changes
May 26, 2025
Member
Author
|
Accidentally deleted the branch in my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more coverage.
May make coverage percent go down as more functions are instantiated.