-
Notifications
You must be signed in to change notification settings - Fork 17
add badge to readme for target standard #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This repo is the clearest about target although if 29 extensions appear here this will get interesting. Badges are new and going into all repos |
Pull Request Test Coverage Report for Build 16027222384Details
💛 - Coveralls |
Co-authored-by: Darius Neațu <[email protected]>
|
It's on target for 26, but also currently builds with 20 (or will as soon as I merge the constexpr fix PR), although there's some polyfill concepts to approximate the dangling check which were added in 23. What question are we trying to answer? |
What version of c++ the library is targeting -- not the minimum level supported. About 1/2 the repos are 26 libraries (all accepted at this point of course) and the other are 29. The badge is meant to 'see that at a glance' |
|
@steve-downey would you have an objection if I moved the license block down to the bottom of the readme as a driveby? The current form of exemplar emphasizes the usage up front which makes sense to me. |
neatudarius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone ahead and made the change so you can see what it looks like in preview.... |
Ok this is only a 12 hour grace period, but I'm merging. @steve-downey if you don't like it ping me and I'll move it back, but I believe it's more consistent with current examplar this way. CI fail btw is some internet issue, nothing in the PR obviously |
Update Beman Standard: extend README.BADGES with Standard Target entries as introduced in #128 Examples - bemanproject/optional#133 bemanproject/exemplar#198

No description provided.