Skip to content

Conversation

@JeffGarland
Copy link
Member

No description provided.

@JeffGarland JeffGarland linked an issue Jul 1, 2025 that may be closed by this pull request
@JeffGarland
Copy link
Member Author

This repo is the clearest about target although if 29 extensions appear here this will get interesting. Badges are new and going into all repos

@coveralls
Copy link

coveralls commented Jul 1, 2025

Pull Request Test Coverage Report for Build 16027222384

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 16000156710: 0.0%
Covered Lines: 304
Relevant Lines: 304

💛 - Coveralls

Co-authored-by: Darius Neațu <[email protected]>
@steve-downey
Copy link
Member

It's on target for 26, but also currently builds with 20 (or will as soon as I merge the constexpr fix PR), although there's some polyfill concepts to approximate the dangling check which were added in 23.

What question are we trying to answer?

@JeffGarland
Copy link
Member Author

It's on target for 26, but also currently builds with 20 (or will as soon as I merge the constexpr fix PR), although there's some polyfill concepts to approximate the dangling check which were added in 23.

What question are we trying to answer?

What version of c++ the library is targeting -- not the minimum level supported. About 1/2 the repos are 26 libraries (all accepted at this point of course) and the other are 29. The badge is meant to 'see that at a glance'

@JeffGarland
Copy link
Member Author

@steve-downey would you have an objection if I moved the license block down to the bottom of the readme as a driveby? The current form of exemplar emphasizes the usage up front which makes sense to me.

https://github.com/bemanproject/exemplar

Copy link
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM, ship it!

@JeffGarland
Copy link
Member Author

@steve-downey would you have an objection if I moved the license block down to the bottom of the readme as a driveby? The current form of exemplar emphasizes the usage up front which makes sense to me.

https://github.com/bemanproject/exemplar

I've gone ahead and made the change so you can see what it looks like in preview....

@JeffGarland
Copy link
Member Author

I've gone ahead and made the change so you can see what it looks like in preview....

Ok this is only a 12 hour grace period, but I'm merging. @steve-downey if you don't like it ping me and I'll move it back, but I believe it's more consistent with current examplar this way.

CI fail btw is some internet issue, nothing in the PR obviously

@JeffGarland JeffGarland merged commit 5d937dd into main Jul 2, 2025
21 of 22 checks passed
@JeffGarland JeffGarland deleted the 132-add-c26-badge branch July 2, 2025 23:45
neatudarius added a commit to bemanproject/beman that referenced this pull request Jul 3, 2025
Update Beman Standard: extend README.BADGES with Standard Target entries as introduced in #128

Examples
- bemanproject/optional#133
bemanproject/exemplar#198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add c++26 badge

5 participants