Feature/export config package #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
requested review from
camio,
neatudarius and
steve-downey
as code owners
ClausKlein
force-pushed
the
feature/export-config-package
branch
from
830a464 to
4868fe2
Compare
This was referenced Dec 6, 2024
Add the verify headers target to the build presets for each compiler.
ClausKlein
force-pushed
the
feature/export-config-package
branch
from
db86d5a to
73fde6b
Compare
steve-downey
reviewed
Dec 6, 2024
Update README Bump minimum cmake version
ClausKlein
force-pushed
the
feature/export-config-package
branch
from
8e074d7 to
fb64c34
Compare
ClausKlein
commented
Dec 12, 2024
Comment on lines
44
to
45
| add_library(beman_optional26 INTERFACE) | ||
| add_library(Beman::Optional26::beman_optional26 ALIAS beman_optional26) |
Contributor
Author
There was a problem hiding this comment.
Note: needs to be consistent with namespace argument install below!
Comment on lines
17
to
41
| install( | ||
| TARGETS beman_optional26 | ||
| FILE_SET beman_optional26_headers | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} | ||
| COMPONENT beman_optional26_development | ||
| ) | ||
|
|
||
| install( | ||
| TARGETS beman_optional26 | ||
| EXPORT beman_optional26_export | ||
| DESTINATION | ||
| ${CMAKE_INSTALL_LIBDIR} | ||
| FILE_SET beman_optional26_headers | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} | ||
| COMPONENT beman_optional26_development | ||
| ) | ||
|
|
||
| install( | ||
| EXPORT beman_optional26_export | ||
| DESTINATION ${INSTALL_CONFIGDIR} | ||
| NAMESPACE Beman::Optional26:: | ||
| FILE beman_optional26-config-targets.cmake | ||
| EXPORT_LINK_INTERFACE_LIBRARIES | ||
| COMPONENT beman_optional26_development | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
NOTE: the target name and the namespace name must be constant to the intern used alias and config package name!
ClausKlein
commented
Dec 14, 2024
|
|
||
| add_subdirectory(include/beman/optional26) | ||
|
|
||
| add_subdirectory(examples) |
Contributor
Author
There was a problem hiding this comment.
TODO: examples should be optional with an option(OPTIONAL26_ENABLE_EXAMLPES ...)
Member
|
@ClausKlein , are you still working on this PR? seems outdated. |
Contributor
Author
|
It was ready since 2 months? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installed
cmake config packageswill be checked too if it is usable in anothercmake project.see 73fde6b