Skip to content

Conversation

@neatudarius
Copy link
Member

@neatudarius neatudarius commented Dec 20, 2024

Issues: bemanproject/beman#77

Proposal: I propose this state because the optional<T&> paper is not accepted into C++26.

Expected README.md:
image

@neatudarius neatudarius marked this pull request as ready for review December 20, 2024 23:11
@coveralls
Copy link

coveralls commented Dec 20, 2024

Coverage Status

coverage: 91.209%. remained the same
when pulling 1ad5034 on neatudarius:LIBRARY_STATUS_UPDATE
into 9e0c8f7 on bemanproject:main.

@neatudarius neatudarius force-pushed the LIBRARY_STATUS_UPDATE branch from b4b72f7 to f4dd612 Compare December 21, 2024 00:05
@neatudarius neatudarius force-pushed the LIBRARY_STATUS_UPDATE branch from f4dd612 to 1ad5034 Compare December 21, 2024 00:08
Copy link

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* [Build and Run Tests](#build-and-run-tests)
* [Build Production, but Skip Tests](#build-production-but-skip-tests)
* [Papers](#papers)
**Implements**: [Give *std::optional* Range Support (P3168R2)](https://wg21.link/P3168R2) and [`std::optional<T&>` (P2988R5)](https://wg21.link/P2988R5)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the example from BEMAN_STANDARD.md:

image

Copy link
Member

@JeffGarland JeffGarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@neatudarius neatudarius merged commit f4cd4b7 into bemanproject:main Dec 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants