Skip to content

Conversation

@wusatosi
Copy link
Member

@wusatosi wusatosi commented Feb 8, 2025

Delegate implementation detail to std::experimental.

Note that this removes support for

  • apple clang
  • msvc
  • LLVM version < 19 (latest default stable for llvm install script is 18, this very much require the front-line release of LLVM)
  • GCC version < 12

This is the complication I was complaining about in #3 .

This also means our project currently only support > C++20.

  • We should document this compiler requirement

@wusatosi
Copy link
Member Author

wusatosi commented Feb 8, 2025

Will likely be able to add back some support once we have a switch and have alternative implementations.

This compiler requirement is pretty crazy for llvm.

@JeffGarland
Copy link
Member

Where are we at with this PR now given that the other PR has 20 as the base?

@robert-andrzejuk
Copy link
Collaborator

@wusatosi I don't understand all the removals.
Do those compilers not support C++20, or do they not compile the example?

We should just remove the compilers that do not support C++20.

@wusatosi
Copy link
Member Author

@wusatosi I don't understand all the removals.
Do those compilers not support C++20, or do they not compile the example?

We should just remove the compilers that do not support C++20.

The removed compilers doesn't have std::experimental

@wusatosi
Copy link
Member Author

Where are we at with this PR now given that the other PR has 20 as the base?

That PR is Irrelevant to this.

Copy link
Member

@JeffGarland JeffGarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this looks ready to go -- lets merge it

@wusatosi wusatosi merged commit 41e7e41 into main Feb 26, 2025
62 checks passed
@wusatosi wusatosi deleted the using-std-experimental branch February 26, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants