-
Notifications
You must be signed in to change notification settings - Fork 7
Fix format + Make project buildable #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c534433
a463033
5650c6b
d705cdc
2c64e3e
e419df0
ca7d280
1a55b42
7208ca9
cc8f4bd
7bf9fb0
478754e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,13 @@ SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |
|
|
||
| # Overview | ||
|
|
||
| During the C++20 cycle [P0052 Generic Scope Guard and RAII Wrapper for the Standard Library](https://wg21.link/P0052) added 4 types: `scope_exit`, `scope_fail`, `scope_success` and `unique_resource` to [LTFSv3](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/n4908#scopeguard). In the intervening time, two standard libraries have implemented support as well as Boost. With the imperative for safety and security in C++ developers need every tool in the toolbox. The authors believe it is time to move this facility into the standard. The paper will re-examine the five year old design and any learning from deployment of the LTFSv3. | ||
| During the C++20 cycle [P0052 Generic Scope Guard and RAII Wrapper for the Standard Library](https://wg21.link/P0052) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I expressed in discourse I believe this change should be reverted and the linter line length restriction removed.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm approving, and if this isn't reverted when you merge I'll fix it in the next PR :)
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. alright |
||
| added 4 types: `scope_exit`, `scope_fail`, `scope_success` | ||
| and `unique_resource` to [LTFSv3](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/n4908#scopeguard). | ||
| In the intervening time, two standard libraries have implemented support as well as Boost. | ||
| With the imperative for safety and security in C++ developers need every tool in the toolbox. | ||
| The authors believe it is time to move this facility into the standard. | ||
| The paper will re-examine the five year old design and any learning from deployment of the LTFSv3. | ||
|
|
||
| For discussions of this library see: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| int main() | ||
| {} | ||
| int main() {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #include <beman/scope/identity.hpp> | ||
| #include <beman/scope/scope.hpp> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #add_executable(beman.scope.tests.identity) | ||
| #target_sources(beman.scope.tests.identity PRIVATE identity.test.cpp) | ||
| add_executable(beman.scope.tests.scope) | ||
| target_sources(beman.scope.tests.scope PRIVATE scope.test.cpp) | ||
|
|
||
| target_link_libraries(beman.scope.tests.scope PRIVATE beman::scope) | ||
|
|
||
| add_test(NAME beman.scope.tests.scope COMMAND beman.scope.tests.scope) |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| int main() { | ||
wusatosi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // TODO: Add tests | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we decide to flatten these directories to TOP/tests and TOP/src -- if we didn't we should. Only for headers do we need the distinction. And yes, I wouldn't be surprised if exemplar if wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not flattened, exemplar is correct here. This is codified in the beman standard, see here.
I believe this is so that we can do a giant beman build, basically merging all beman projects together and check if they can compile together as a single library.
We decided to not flatten
examplesdirectory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boost does a giant build and doesn't require this -- we should rediscuss this point.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the directory structure is not negotiable here. You will have to change the beman standard.
Feel free to bring it up at the next sync.
Note that it might be a little bit too late to change this, all current projects follow this folder structure. You will have to update a lot of current projects if you want to change this rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's never too late to change things