Use simply include instead of find_package #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
requested review from
bretbrownjr,
dietmarkuehl,
ednolan,
neatudarius,
steve-downey and
wusatosi
as code owners
Pull Request Test Coverage Report for Build 20559759891Details
💛 - Coveralls |
JeffGarland
reviewed
Dec 28, 2025
| # gersemi: on | ||
|
|
||
| find_package(beman-install-library REQUIRED) | ||
| include(infra/cmake/beman-install-library-config.cmake) |
Member
There was a problem hiding this comment.
right -- I think this is a better way to do this than the find package obviousl
Contributor
Author
There was a problem hiding this comment.
Note: CMAKE_PREFIX_PATH is a list and should appended, not set.
JeffGarland
approved these changes
Dec 28, 2025
Member
JeffGarland
left a comment
JeffGarland
left a comment
There was a problem hiding this comment.
Looks good to me thanks @ClausKlein :)
JeffGarland
added a commit
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.