Update transform_view to exemplar-based INTERFACE configuration #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ednolan
force-pushed
the
enolan_exemplarify2
branch
from
ac3f091 to
7bedbab
Compare
ednolan
force-pushed
the
enolan_exemplarify2
branch
2 times, most recently
from
756dedc to
0f8f41d
Compare
ednolan
force-pushed
the
enolan_exemplarify2
branch
from
0f8f41d to
f5507d4
Compare
JeffGarland
reviewed
Jan 5, 2026
|
|
||
| add_subdirectory(include/beman/transform_view) | ||
|
|
||
| include(CTest) |
Member
There was a problem hiding this comment.
Suggested change
| include(CTest) |
This is handled in line 51 (enable_testing includes ctest) under the condition that tests are being built
JeffGarland
reviewed
Jan 5, 2026
| $ build/gcc-release/examples/beman.transform_view.examples.transform_view_direct_usage | ||
| lower | ||
| The `debug` presets are designed to aid development, so it has debugging | ||
| instrumentation enabled and many sanitizers enabled. |
Member
There was a problem hiding this comment.
I sort of dislike that we've removed the specifics that were put here....
JeffGarland
reviewed
Jan 5, 2026
|
|
||
| <details> | ||
| <summary> Use beman.transform_view directly from C++ </summary> | ||
|
|
Member
There was a problem hiding this comment.
The statement below is valid -- we really need to separate the readme for building versus 'using in your project'.
tzlaine
approved these changes
Jan 6, 2026
Collaborator
tzlaine
left a comment
tzlaine
left a comment
There was a problem hiding this comment.
This all seems fine to me. Are Jeff's comments blocking this? I'm unclear if I should merge it as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.