Skip to content

Add CMake option controlling whether targets for building paper are added #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ednolan merged 1 commit into from
Nov 13, 2024
Merged

Add CMake option controlling whether targets for building paper are added #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ jobs:
submodules: recursive
- name: Run
run: |
./ci.sh -DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined -fsanitize-undefined-trap-on-error -coverage'
- name: Paper
run: |
cmake --build ./build -t p2728
./ci.sh -DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined -fsanitize-undefined-trap-on-error -coverage' -DUTF_VIEW_BUILD_PAPER=ON
- name: Coverage
run: |
lcov --directory ./build --capture --output-file ./build/coverage_all.info
Expand Down
10 changes: 9 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
cmake_minimum_required(VERSION 3.27)
project(utf_view CXX)

option(
UTF_VIEW_BUILD_PAPER
"Enable building paper. Default: OFF. Values: { ON, OFF }."
OFF
)

if (BUILD_TESTING)
include(CTest)
endif()
Expand All @@ -29,4 +35,6 @@ endif()

add_subdirectory(src/utf_view)

add_subdirectory(paper)
if (UTF_VIEW_BUILD_PAPER)
add_subdirectory(paper)
endif()
2 changes: 1 addition & 1 deletion paper/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ add_custom_command(
COMMAND SRCDIR=${CMAKE_CURRENT_SOURCE_DIR} OUTDIR=${CMAKE_CURRENT_BINARY_DIR} make -C ${CMAKE_CURRENT_SOURCE_DIR}/../deps/wg21 html
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/P2728.md
VERBATIM)
add_custom_target(p2728 DEPENDS P2728.html)
add_custom_target(p2728 ALL DEPENDS P2728.html)