-
Notifications
You must be signed in to change notification settings - Fork 5
More December docs sync #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for bemanproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| 1. [Apache License v2.0 with LLVM Exceptions](https://llvm.org/LICENSE.txt) | ||
| 2. [Boost Software License 1.0](https://www.boost.org/LICENSE_1_0.txt) | ||
| 3. [The MIT License](https://opensource.org/license/mit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffGarland , I think this is the only relevant change.
Rest of the PR is trigger by formatting changes.
|
@mguludag / @RaduNichita , why is this check failing now? https://github.com/bemanproject/website/actions/runs/20226495044/job/58059054163?pr=116 I don't think I want to run linters of png files. Or MD linter here (in website repo). It should be exactly mirror of files from beman repo (it's OK to enforce some linting there). L.E. I see it! it's because of #115. @mguludag can we exclude some directories? |
To me any linting checks need to be in Beman repo so that this can just be a copy here. I'd note that we're mostly removing the linting for text otherwise because it's basically 99%+ false positives (aka whitespace that doesn't matter enforcement) instead of actual issues. |
there is an option to exclude folders or particular file types: https://docs.trunk.io/code-quality/overview/linters/ignoring-issues-and-files#ignoring-multiple-files if we need to exclude some folders maybe I'll create a separate PR for this |
We don't need to exclude some file types. I will give you an example for MD files:
@mguludag , please do a PR to exclude some directories: |
JeffGarland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Follow-up after #113 . Issue #112
New diff check:
as expected!
We can also validated 100% sync with