fix: deduplicate base tools in buildAllowedTools#154
Open
ben-rogerson wants to merge 2 commits intomainfrom
Open
fix: deduplicate base tools in buildAllowedTools#154ben-rogerson wants to merge 2 commits intomainfrom
ben-rogerson wants to merge 2 commits intomainfrom
Conversation
When a read-only or full-permission agent explicitly declared read/glob/grep in its tools array, those tools would appear twice in the resulting allowedTools string (once from the hardcoded baseline, once from the user's list). Wrap the concatenated arrays in a Set to deduplicate before joining. Add regression tests to verify no duplicates appear for both permission levels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a read-only or full-permission agent explicitly declared read/glob/grep in its tools array, those tools would appear twice in the resulting allowedTools string (once from the hardcoded baseline, once from the user's list). Wrap the concatenated arrays in a Set to deduplicate before joining. Add regression tests to verify no duplicates appear for both permission levels.
Test plan
pnpm typecheckpnpm lintpnpm test