fix: re-prompt required env variables until non-empty#160
Merged
Conversation
The promptForEnv function was accepting empty answers for required fields, writing empty strings to .env and causing silent failures. Wrap the prompt in a do-while loop that repeats until the user provides a non-empty value (or signals Ctrl+C).
ben-rogerson
force-pushed
the
fix/required-env-prompt-accepts-empty
branch
from
3b21170 to
0d4daed
Compare
Add stream-injection params to promptForEnv (defaults to process stdin/stdout) so the re-prompt loop can be unit-tested without spawning a process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The promptForEnv function was accepting empty answers for required fields, writing empty strings to .env and causing silent failures. Wrap the prompt in a do-while loop that repeats until the user provides a non-empty value (or signals Ctrl+C).
Test plan
pnpm typecheckpnpm lintpnpm test