fix: parse @ref suffix from git URLs in classifySpecifier#162
Merged
Conversation
The templates README documents tag/branch pinning via `url@v2.0.0` syntax, but classifySpecifier was treating the suffix as part of the URL. Now the resolver extracts @ref into a separate field and passes it to cloneToTemp, so git clone receives the correct reference without the unparsed suffix.\n\nAdds tests for HTTPS and SSH-style git URLs with @ref suffixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The templates README documents tag/branch pinning via
url@v2.0.0syntax, but classifySpecifier was treating the suffix as part of the URL. Now the resolver extracts @ref into a separate field and passes it to cloneToTemp, so git clone receives the correct reference without the unparsed suffix.\n\nAdds tests for HTTPS and SSH-style git URLs with @ref suffixes.Test plan
pnpm typecheckpnpm lintpnpm test