Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/template-manifest-not-strict.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@generata/core": patch
---

fix: make TemplateManifest schema strict to reject unknown keys
7 changes: 7 additions & 0 deletions packages/core/src/cli/manifest.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ describe("parseManifest", () => {
it("rejects bin entry missing name", () => {
throws(() => parseManifest({ name: "x", description: "y", requiredBins: [{}] }));
});

it("rejects unknown top-level keys", () => {
throws(
() => parseManifest({ name: "x", description: "y", requireBins: [] }),
/requireBins/,
);
});
});

describe("loadManifest", () => {
Expand Down
20 changes: 11 additions & 9 deletions packages/core/src/cli/manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,17 @@ const RequiredEnvEntry = z.object({
optional: z.boolean().default(false),
});

export const TemplateManifest = z.object({
name: z.string(),
description: z.string(),
engineVersion: z.string().optional(),
requiredBins: z.array(RequiredBin).default([]),
requiredEnv: z.record(z.string(), RequiredEnvEntry).default({}),
installPaths: z.record(z.string(), z.string()).default({}),
postInstall: z.string().optional(),
});
export const TemplateManifest = z
.object({
name: z.string(),
description: z.string(),
engineVersion: z.string().optional(),
requiredBins: z.array(RequiredBin).default([]),
requiredEnv: z.record(z.string(), RequiredEnvEntry).default({}),
installPaths: z.record(z.string(), z.string()).default({}),
postInstall: z.string().optional(),
})
.strict();
export type TemplateManifest = z.infer<typeof TemplateManifest>;

export function parseManifest(input: unknown): TemplateManifest {
Expand Down
Loading