feat(core): loop iteration via .step() with each:#83
Open
ben-rogerson wants to merge 17 commits intomainfrom
Open
feat(core): loop iteration via .step() with each:#83ben-rogerson wants to merge 17 commits intomainfrom
ben-rogerson wants to merge 17 commits intomainfrom
Conversation
Drives the full path: builder accepts loop step, precheck passes, engine dispatches to runLoopStep, sub-workflow runs per item, manifest is written, and `<step-id>_manifest` flows downstream to the next step. Also fixes the engine's loop-step deps wiring: the inner runWorkflow now forwards deps to sub-workflow runs so a mocked runAgent applies to both outer and sub steps. Without this, the integration test (and any caller mocking runAgent) would silently fall back to the real CLI inside loop sub-runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
each:to.step()so a workflow step can run a sub-workflow once per item from a directory glob, JSON file, or function.<work_dir>/.generata/loops/<workflow>-<step>-<run>.json, surfaced downstream as<step-id>_manifest.concurrency(sequential by default),onFailure: "halt" | "continue",onItemFailfor per-failure side effects, andmaxRetriesper iteration.@generata/core:LoopWorkflowStepandEachSource.Test plan
pnpm fmtpnpm lintpnpm typecheckpnpm test(262 passing)each: { items: ... }loop end-to-end against the live CLI before depending on this in production.