Remove some side effects and add an optional to save log to file as well. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standalone logger. Bug fixs. INFO, WARNING etc now works. Now log could be configured to be written to file as well.
INFO level logging is used and is expected in stdout. * Program now could handle file object output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi benley:
I found your code while trying to find a more permanent solution to logging. Nice work!
Just fix something and add something to make it better.
twice. After some debugging, I found this was due to the root logger gets two
handlers since you add one more glog-style formatter handler. So if there are
other libraries also add some handler to the root logger, which is my case,
the log will be printed multiple times. To fix this, I use a standalone
handler and set
logger.propagate = False. So the side effects areremoved.
usage is updated in the README.
Shawn
Best