Remove DuplicatePropertyError #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is sometimes desirable to redefine a property in a subclass (e.g. to override a default value set in parent class). This removes checks for duplicate properties when using a base class derived from schema.DocumentSchema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sometimes desirable to redefine a property in a subclass (e.g. to
override a default value set in parent class). This removes checks for
duplicate properties when using a base class derived from
schema.DocumentSchema.
We talked in #couchdbkit about overriding a default value for a property in a subclass. I had thought I might just be able to redefine the property in the subclass but ran into DuplicatePropertyError and as mentioned, here's a pull request.
Now, this goes to the extreme of just stripping that guard completely. As I was writing it, I thought, it might be worthwhile to, at the very least, make sure the property in the subclass was of the same type, but maybe not. I'd be interested in your thoughts on that.