Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 29 - relax having a .couchapprc file #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ryanramage
Copy link
Collaborator

This will solve #29. @benoitc, can you have a quick review? This is my first erlang PR :)

@benoitc
Copy link
Owner

benoitc commented Oct 17, 2012

The reason a .couchapprc is(was?) needed is the same as in git it allows us to make sure we won't go in an infinite loop accros folders. Indeed it's used to send the couchapp from any folders inside just like git. ie if you are in _attachments/ you could sitill push the couchapp. Not sure it's a good change sinc eit remove some simplicity. What's your reasonning?

@ryanramage
Copy link
Collaborator Author

The patch still allows for detecting a .couchapprc file in a higher level
dir. This still works.

Most build tools expect to be run from the root dir, so I am not sure if
the feature of running in child dir is important.

My reasons:

  • I want to reduce the amount of files a newbie has so see in a couchapp.
    It is distracting, And a couchapprc is in no way required to push.
  • I also want to move to an attachment first style. I have code for this in
    my develop branch. This will allow for both styles of couchapp, the
    traditional, and webstyle. That way people can push a simple index.html in
    a folder if they want to. no other stuff.

On Wed, Oct 17, 2012 at 11:09 AM, Benoit Chesneau
[email protected]:

The reason a .couchapprc is(was?) needed is the same as in git it allows
us to make sure we won't go in an infinite loop accros folders. Indeed it's
used to send the couchapp from any folders inside just like git. ie if you
are in _attachments/ you could sitill push the couchapp. Not sure it's a
good change sinc eit remove some simplicity. What's your reasonning?


Reply to this email directly or view it on GitHubhttps://github.com//pull/31#issuecomment-9535316.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants