Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating .sol files with errors #91

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Updating .sol files with errors #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f67dbc2
IERC4626.sol
Kwaitow Nov 29, 2024
840d80e
IERC4626.sol
Kwaitow Nov 29, 2024
7a36c82
IERC4626.sol
Kwaitow Nov 29, 2024
7273f9d
StdUtils.sol
Kwaitow Nov 29, 2024
3f81a0f
Revert changes in IERC4626.sol from commit f67dbc2
Kwaitow Nov 30, 2024
7245932
README.md
Kwaitow Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/foundry-erc20/lib/openzeppelin-contracts/contracts/interfaces/IERC4626.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ interface IERC4626 is IERC20, IERC20Metadata {
function maxRedeem(address owner) external view returns (uint256 maxShares);

/**
* @dev Allows an on-chain or off-chain user to simulate the effects of their redeemption at the current block,
* @dev Allows an on-chain or off-chain user to simulate the effects of their redemption at the current block,
* given current on-chain conditions.
*
* - MUST return as close to and no more than the exact amount of assets that would be withdrawn in a redeem call
Expand Down
2 changes: 1 addition & 1 deletion apps/foundry-erc20/lib/openzeppelin-contracts/lib/forge-std/src/StdUtils.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ abstract contract StdUtils {
}

/// @dev Compute the address a contract will be deployed at for a given deployer address and nonce
/// @notice adapated from Solmate implementation (https://github.com/Rari-Capital/solmate/blob/main/src/utils/LibRLP.sol)
/// @notice adapted from Solmate implementation (https://github.com/Rari-Capital/solmate/blob/main/src/utils/LibRLP.sol)
function computeCreateAddress(address deployer, uint256 nonce) internal pure virtual returns (address) {
// forgefmt: disable-start
// The integer zero is treated as an empty byte string, and as a result it only has a length prefix, 0x80, computed via 0x80 + 0.
Expand Down
2 changes: 1 addition & 1 deletion apps/foundry-erc20/lib/openzeppelin-contracts/lib/forge-std/src/interfaces/IERC4626.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ interface IERC4626 is IERC20 {
/// - MUST NOT revert.
function maxRedeem(address owner) external view returns (uint256 maxShares);

/// @notice Allows an on-chain or off-chain user to simulate the effects of their redeemption at the current block,
/// @notice Allows an on-chain or off-chain user to simulate the effects of their redemption at the current block,
/// given current on-chain conditions.
/// @dev
/// - MUST return as close to and no more than the exact amount of assets that would be withdrawn in a redeem call
Expand Down
2 changes: 1 addition & 1 deletion apps/gelato-vrf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,6 @@ Transaction hash: 0x1a33e33970c0c4e89589e863b8833d7da5138a4f13b7cc02da9b2d978639

After your randomness request has been made, you can monitor and analyze it here:

[Here](https://app.gelato.network/functions/task/0x904a1cdf1d09ec7f237a887bd6924d9116351a329c5f52a64d62bdcb9b9b5568:80084?origin=vrf) is an example task from the app that shows the fullfilled randomness
[Here](https://app.gelato.network/functions/task/0x904a1cdf1d09ec7f237a887bd6924d9116351a329c5f52a64d62bdcb9b9b5568:80084?origin=vrf) is an example task from the app that shows the fulfilled randomness

![Monitoring](./assets/monitoring.png)