Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schamas): add required properties to objects and allowed logo sources #61

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

bearpong
Copy link
Collaborator

This prevents wrongful objects in metadata arrays.

I'm also removing ipfs as allowed URI since FE does not support it right now and it wouldn't make sense to allow them right now. At the same time, due to CSP restrictions images should can only be allowed by specific domains as defined in the schema.

@bearpong bearpong marked this pull request as ready for review March 18, 2025 11:38
Copy link
Collaborator

@codingwithmanny codingwithmanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codingwithmanny codingwithmanny merged commit 65855c5 into main Mar 18, 2025
1 check passed
@codingwithmanny codingwithmanny deleted the hotfix/add-missing-tags branch March 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants