Skip to content

Fixed BLS test comments #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzogentile404 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fixed BLS test comments #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gnark/src/test/java/org/hyperledger/besu/nativelib/gnark/BLS12G1PointDecodingTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

public class BLS12G1PointDecodingTests {

// Valid G1 point from existing test data - 128 bytes with proper padding
// Valid G1 point - 128 bytes (256 hex chars)
private static final String VALID_G1_POINT =
"0000000000000000000000000000000012196c5a43d69224d8713389285f26b98f86ee910ab3dd668e413738282003cc5b7357af9a7af54bb713d62255e80f56" +
"0000000000000000000000000000000006ba8102bfbeea4416b710c73e8cce3032c31c6269c44906f8ac4f7874ce99fb17559992486528963884ce429a992fee";
Expand All @@ -34,7 +34,7 @@ public class BLS12G1PointDecodingTests {
"00000000000000000000000000000000177b39d2b8d31753ee35033df55a1f891be9196aec9cd8f512e9069d21a8bdbf693bd2e826e792cd12cb554287adf4ca" +
"0000000000000000000000000000000003c0f5770509862f754fc474cb163c41790d844f52939e2dec87b97c2a707831a4043ab47014d501f67862e95842ba5a";

// G1 point that's on curve but not in subgroup - use a simple test point (256 hex chars)
// G1 point that's on curve but not in subgroup
private static final String G1_POINT_NOT_IN_SUBGROUP =
"00000000000000000000000000000000054a4326bbddbdbbca126659e6686984046d2fa49270742e5b6d9017734acf2801f370eebe7af29dfc8d50483609dc00" +
"000000000000000000000000000000001713e9ef64254fe96d874d16e33636f186e30d7e476db9f49a16698b771f10e0f8f08e5d8dba621b887c0d257cbd8eac";
Expand Down
4 changes: 2 additions & 2 deletions gnark/src/test/java/org/hyperledger/besu/nativelib/gnark/BLS12G2PointDecodingTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

public class BLS12G2PointDecodingTests {

// Valid G2 point - zero point (point at infinity) - 256 bytes (512 hex chars)
// Valid G2 point - 256 bytes (512 hex chars)
private static final String VALID_G2_POINT =
"00000000000000000000000000000000124aca13d9ead2e5194eb097360743fc996551a5f339d644ded3571c5588a1fedf3f26ecdca73845241e47337e8ad990" +
"000000000000000000000000000000000299bfd77515b688335e58acb31f7e0e6416840989cb08775287f90f7e6c921438b7b476cfa387742fcdc43bcecfe45f" +
Expand All @@ -38,7 +38,7 @@ public class BLS12G2PointDecodingTests {
"00000000000000000000000000000000153a9002d117a518b2c1786f9e8b95b00e936f3f15302a27a16d7f2f8fc48ca834c0cf4fce456e96d72f01f252f4d084" +
"000000000000000000000000000000001091fc53100190db07ec2057727859e65da996f6792ac5602cb9dfbc3ed4a5a67d6b82bd82112075ef8afc4155db2621";

// G2 point that's on curve but not in subgroup - use a simple test point (512 hex chars)
// G2 point that's on curve but not in subgroup
private static final String G2_POINT_NOT_IN_SUBGROUP =
"000000000000000000000000000000000380f5c0d9ae49e3904c5ae7ad83043158d68fa721b06b561e714b71a2c48c2307b5258892f999a882bed3549a286b7f" +
"0000000000000000000000000000000004886f7f17a8e9918b4bfa8ebe450b0216ed5e1fa103dfc671332dc38b04ed3105526fb0dda7e032b6fb67debf9f0bc5" +
Expand Down