enable bal parallelization for all blocks#10234
Merged
matkt merged 8 commits intobesu-eth:mainfrom Apr 16, 2026
Merged
Conversation
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR changes how ParallelBlockTransactionProcessor retrieves the world state so it uses the provided blockHeader instead of always using the chain head header.
Changes:
- Removed the chain-head parent check in
getWorldState. - Switched world state lookup from
chainHeadHeaderto the providedblockHeader.
mirgee
requested changes
Apr 15, 2026
daniellehrner
requested changes
Apr 15, 2026
Contributor
daniellehrner
left a comment
There was a problem hiding this comment.
The existing tests have been updated, but no new tests have been added to actually test the new behavior. I think we would need those to avoid regressions
Contributor
|
No strong opinions, but I had use my new power to "Request Changes" :) |
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Contributor
Author
|
Thanks for the review I added more tests and also updated the code |
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
mirgee
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This pull request makes a targeted change to the logic for retrieving the world state in
ParallelBlockTransactionProcessor. The update ensures that the world state is fetched based on the currentblockHeaderrather than always using the chain head.World state retrieval logic:
getWorldStateto use the providedblockHeaderfor world state lookup, removing a restrictive check against the chain head and simplifying the retrieval process.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests