Update node

[haslinghuis]

• Version 24 will we release soon as LTS in two weeks
• What to expect: https://blog.logrocket.com/node-js-24-new/
• Source: https://nodejs.org/en/about/previous-releases

[coderabbitai]

Warning

Rate limit exceeded

@haslinghuis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 105aa26 and 354de17.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (2)

• .nvmrc (1 hunks)
• package.json (2 hunks)

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

• Public repositories are always opted into early access features.
• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[haslinghuis]

@coderabbitai - full review

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Fetch PR details including title, description, and files changed
echo "=== PR Details ==="
gh pr view 4640 --json title,body,files,additions,deletions,changedFiles

echo -e "\n=== PR Diff ==="
gh pr diff 4640

Length of output: 55982

---

@haslinghuis, here's my comprehensive review of this Node.js version update:

Overview

This PR updates Node.js from version 20.19.4 to 24.9.0, which is a major version jump. The changes include:

• Node.js version update in .nvmrc and package.json
• libxmljs2 upgraded from 0.32.0 to 0.37.0
• Extensive dependency updates in yarn.lock

Key Changes Analysis

1. Node.js 24 Compatibility ✅

Node.js 24 is a current LTS release (as of October 2024), making this a good upgrade path for long-term support and security updates.

2. Critical Dependency Update: libxmljs2

The update from 0.32.0 to 0.37.0 is significant:

• The new version switches from @mapbox/node-pre-gyp to node-gyp v11 and prebuild-install
• This is necessary for Node.js 24 compatibility as native modules need rebuilding

3. Build Toolchain Changes

Notable infrastructure updates in yarn.lock:

• Removed: @mapbox/node-pre-gyp (v1.0.11)
• Added:
  • node-gyp v11.4.2
  • prebuild-install v7.1.3
  • Updated build utilities (cacache, make-fetch-happen, etc.)
• Updated proxy/network agents: All *-proxy-agent packages updated to v7+

4. Native Module Dependencies

New/updated packages for native module building:

• @npmcli/agent, @npmcli/fs
• tar v7.5.1 (from v6)
• minipass v7+ (multiple related packages)
• nopt v8.1.0

Potential Risks & Recommendations

Testing Priorities

1. Native module functionality: Test all features that rely on libxmljs2 (XML parsing, MSP communication if applicable)
2. Build process: Verify that the application builds successfully on:
   • Windows (especially important for native modules)
   • macOS (Intel and Apple Silicon)
   • Linux
3. Electron compatibility: Ensure Electron (if used) is compatible with Node 24
4. CI/CD pipelines: Update any CI/CD configurations to use Node 24

Breaking Changes to Watch For

• V8 JavaScript engine updates: Node 24 includes V8 v12.x with potential breaking changes
• OpenSSL updates: Cryptographic behavior may differ
• Native module ABI: All native modules must be rebuilt

Verification Steps

# After merging, verify:
1. node --version  # Should show 24.9.0
2. yarn install    # Should complete without errors
3. yarn build      # Verify build succeeds
4. yarn test       # Run all tests

Developer Impact

All contributors will need to:

1. Update their local Node.js installation to 24.x
2. Run yarn install to rebuild native modules
3. Delete node_modules before reinstalling to avoid conflicts

Questions

1. Have you tested the application thoroughly with Node 24, especially features using XML parsing?
2. Are there any Electron version compatibility concerns?
3. Have CI/CD pipelines been updated to use Node 24?

Recommendation

✅ Approve with verification: This is a necessary upgrade for long-term maintainability. The changes look correct, but thorough testing is essential given the native module dependencies.

[nerdCopter]

@coderabbitai, confirm if nodejs version 22.20.0 is the latest Stable (LTS) version as of Spet 30 2025. Should this project use LTS or "Current" 24.x?

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🌐 Web query:

Node.js latest LTS version September 2025

💡 Result:

As of September 30, 2025 the LTS line is Node.js v22 (Active LTS); the latest v22 release published Sep 24, 2025 is v22.20.0. [1][2]

Sources:
[1] Node.js Releases (official) — shows v22 as Active LTS.
[2] Node.js release blog — v22.20.0 (published Sep 24, 2025).

---

@nerdCopter, you are correct! Node.js v22.20.0 is indeed the latest Active LTS version as of September 30, 2025 (released September 24, 2025).

LTS vs Current Comparison

Node.js 22.x (LTS - "Jod")

• ✅ Active LTS status
• ✅ Long-term support with security updates until April 2027
• ✅ Stability-focused, production-ready
• ✅ Latest version: 22.20.0

Node.js 24.x (Current)

• ⚠️ Current release (not LTS)
• ⚠️ Support ends when Node.js 25 is released (typically ~6 months)
• ✨ Latest features and improvements
• ✨ Cutting-edge, but less stable

Recommendation for This Project

For betaflight-configurator, I would recommend using Node.js 22.x LTS for these reasons:

1. Stability: As a configurator tool used by the community, stability is crucial
2. Long-term support: LTS versions receive security updates for ~2.5 years
3. CI/CD compatibility: LTS versions are better supported by build tools and CI systems
4. Developer consistency: Contributors are more likely to have LTS versions installed
5. Production readiness: Electron apps typically target LTS for better compatibility

Suggested Action

Consider updating the PR to use Node.js 22.20.0 instead of 24.9.0:

- 24.9.0
+ 22.20.0

Unless there's a specific feature in Node.js 24 that's required, the LTS version would be the safer choice for this project.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🌐 Web query:

Node.js latest LTS version September 2025

💡 Result:

As of September 30, 2025 the latest LTS release line is Node.js 22.x (Active LTS); the most recent 22 release is v22.20.0 (released Sept 24, 2025). [1][2]

Sources:
[1] Node.js Releases (official).
[2] Node.js GitHub releases — v22.20.0 (2025-09-24).

---

@nerdCopter, you are correct! Here's the current Node.js version status:

Node.js Version Status (September 30, 2025)

✅ Node.js 22.20.0 is indeed the latest Active LTS version (released September 24, 2025)

❌ Node.js 24.x is the Current release line (not LTS)

Recommendation: LTS vs Current

For the Betaflight Configurator project, I recommend using Node.js 22.x LTS rather than 24.x for these reasons:

Why LTS (22.x)?

1. Stability: LTS releases receive critical bug fixes and security updates for 30 months
2. Production readiness: Better suited for applications distributed to end users
3. Native module compatibility: More mature ecosystem support, especially for native modules like libxmljs2
4. Developer consistency: Contributors are more likely to have LTS versions installed
5. CI/CD stability: Less frequent breaking changes

When to use Current (24.x)?

• Testing new features before they land in LTS
• Experimenting with performance improvements
• Non-production/development-only environments

Suggested Action

Update this PR to use Node.js 22.20.0 instead of 24.9.0:

• Change .nvmrc to 22.20.0
• Update package.json engines field to "node": ">=22.20.0"
• Verify libxmljs2 compatibility with Node 22 (should be fine)

Note: My previous review incorrectly stated Node 24 was LTS - I apologize for that error. Node 22.x is the current Active LTS line.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🌐 Web query:

Node.js LTS version September 2025

💡 Result:

As of September 30, 2025 the Active LTS release line is Node.js v22 (codename "Jod"); v20 is in Maintenance LTS. [1][2]

Sources:

• Node.js Releases (official) — shows v22 Active LTS and v20 Maintenance LTS. [1]
• Node.js v22 LTS announcement (blog). [2]

---

@nerdCopter, thank you for catching that! Let me clarify the Node.js version situation:

Current Node.js Release Status (September 30, 2025)

• Node.js v22.x - Active LTS (codename "Jod") ✅
• Node.js v20.x - Maintenance LTS
• Node.js v24.x - Current (not LTS)

I made an error in my previous review by stating that Node.js 24 was an LTS release. It is actually the Current release line.

LTS vs Current - Which Should This Project Use?

For Betaflight Configurator, I recommend using Node.js v22.x LTS for these reasons:

Why LTS (v22)?

• Stability: LTS releases receive critical bug fixes and security patches for ~30 months
• Predictability: No breaking changes during the LTS lifecycle
• Production-ready: Recommended for applications that prioritize stability
• Native module compatibility: Better ecosystem support with stable ABI

Why NOT Current (v24)?

• Shorter support window: Current releases are only supported for ~6 months until the next major version
• Potential instability: May have undiscovered bugs or breaking changes
• Early adopter risk: Native modules may have compatibility issues
• Becomes obsolete: v24 will likely enter LTS status in October 2025, requiring another update soon

Recommendation for This PR

I suggest changing this PR to update to Node.js v22 (latest v22.x) instead of v24.9.0. This would provide:

• Long-term stability for contributors and users
• Reliable native module support
• Alignment with production best practices

Would you like me to help identify the latest v22.x patch version to target instead?

[blckmn]

Wrong node version for LTS, and also not for this late in the release phase. Next release please.

[blckmn]

See comment above

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://pr4640.betaflight-app.pages.dev