-
Notifications
You must be signed in to change notification settings - Fork 191
Requesting for new manufacturer ID #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Requesting add of a new manufacturer ID: FRFL
I have read all your FC design requirements. I have sent all my files to [email protected] |
Thank you. Please be patient as we handle many requests. |
Ok! Thank you |
|
yes, typo, sorry! |
Manufacturer ID: FLBD Name: FlashBird
WalkthroughAdds a new manufacturer entry (FLBD / FlashBird with contact URL https://github.com/lecui) to Manufacturers.md, inserted after the FLao line. No logic or control flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Manufacturers.md (1)
52-52
: Fix markdownlint MD034 by wrapping the bare URL.markdownlint flagged a bare URL on Line 52. Wrap the URL in angle brackets to satisfy MD034 without changing table style.
Apply this diff:
-|FLBD|FlashBird|https://github.com/lecui| +|FLBD|FlashBird|<https://github.com/lecui>|
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
📚 Learning: 2025-08-14T17:46:20.018Z
Learnt from: haslinghuis
PR: betaflight/config#863
File: Manufacturers.md:116-116
Timestamp: 2025-08-14T17:46:20.018Z
Learning: In Betaflight's Manufacturers.md file, company name formatting with "Co." shows variation: "Co., Ltd." (6 times) is most common, followed by "Co., LTD" and "Co., Ltd" (3 times each), while "Co.,Ltd." without space after comma appears only once.
Applied to files:
Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
52-52: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
Manufacturers.md (1)
52-52
: LGTM: valid 4-char ID and correctly placed alphabetically.FLBD meets the 4 ASCII-character requirement and is correctly inserted after FLAO and before FLCO. Name and contact look consistent with existing entries.
@sugaarK have you received any schematics from this company? Do we have a Discord channel setup? |
Nope no contact Email me @lecui [email protected] |
This should not be merged until we have an actual target PR from this manufacturer. |
Done |
Requesting add of a new manufacturer ID: FRFL
I want to create my own FC project.
Summary by CodeRabbit
New Features
Documentation
Chores