Skip to content

Conversation

lecui
Copy link

@lecui lecui commented May 8, 2025

Requesting add of a new manufacturer ID: FRFL
I want to create my own FC project.

Summary by CodeRabbit

  • New Features

    • None
  • Documentation

    • Updated the official manufacturer ID list with a new entry: FLBD (FlashBird), including contact URL.
    • Clarifies available manufacturers for users referencing the list.
  • Chores

    • Expanded the manufacturer data list; no functional changes or deletions.

Requesting add of a new manufacturer ID: FRFL
@haslinghuis
Copy link
Member

haslinghuis commented May 8, 2025

@haslinghuis
Copy link
Member

@lecui
Copy link
Author

lecui commented May 8, 2025

Please checkout https://betaflight.com/docs/development/manufacturer/config-target-guidance

I have read all your FC design requirements. I have sent all my files to [email protected]
I need to be added as a manufacturer to the list to continue my development

@haslinghuis
Copy link
Member

Thank you. Please be patient as we handle many requests.

@lecui
Copy link
Author

lecui commented May 8, 2025

Thank you. Please be patient as we handle many requests.

Ok! Thank you
Maybe FlashBird free?
Manufacturer ID: FLDB
Name: FlashBird

@haslinghuis
Copy link
Member

FLBD

@lecui
Copy link
Author

lecui commented May 8, 2025

FLBD

yes, typo, sorry!

Manufacturer ID: FLBD
Name: FlashBird
@haslinghuis haslinghuis added the New manufacturer Add manufacturer label May 9, 2025
Copy link
Contributor

coderabbitai bot commented Aug 21, 2025

Walkthrough

Adds a new manufacturer entry (FLBD / FlashBird with contact URL https://github.com/lecui) to Manufacturers.md, inserted after the FLao line. No logic or control flow changes.

Changes

Cohort / File(s) Summary
Documentation: Manufacturer list
Manufacturers.md
Inserted a new row for FLBD (FlashBird) with contact URL https://github.com/lecui after FLao in the official Manufacturer IDs table.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ot0tot
  • blckmn

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Manufacturers.md (1)

52-52: Fix markdownlint MD034 by wrapping the bare URL.

markdownlint flagged a bare URL on Line 52. Wrap the URL in angle brackets to satisfy MD034 without changing table style.

Apply this diff:

-|FLBD|FlashBird|https://github.com/lecui|
+|FLBD|FlashBird|<https://github.com/lecui>|
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dc5308b and 3debc7c.

📒 Files selected for processing (1)
  • Manufacturers.md (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
📚 Learning: 2025-08-14T17:46:20.018Z
Learnt from: haslinghuis
PR: betaflight/config#863
File: Manufacturers.md:116-116
Timestamp: 2025-08-14T17:46:20.018Z
Learning: In Betaflight's Manufacturers.md file, company name formatting with "Co." shows variation: "Co., Ltd." (6 times) is most common, followed by "Co., LTD" and "Co., Ltd" (3 times each), while "Co.,Ltd." without space after comma appears only once.

Applied to files:

  • Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md

52-52: Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
Manufacturers.md (1)

52-52: LGTM: valid 4-char ID and correctly placed alphabetically.

FLBD meets the 4 ASCII-character requirement and is correctly inserted after FLAO and before FLCO. Name and contact look consistent with existing entries.

@nerdCopter nerdCopter requested a review from a team August 29, 2025 19:15
haslinghuis
haslinghuis previously approved these changes Aug 29, 2025
@ot0tot
Copy link
Contributor

ot0tot commented Aug 31, 2025

@sugaarK have you received any schematics from this company? Do we have a Discord channel setup?

@sugaarK
Copy link
Member

sugaarK commented Aug 31, 2025

Nope no contact

Email me @lecui [email protected]

@ot0tot
Copy link
Contributor

ot0tot commented Aug 31, 2025

This should not be merged until we have an actual target PR from this manufacturer.

@sugaarK sugaarK dismissed haslinghuis’s stale review August 31, 2025 04:39

Don’t merge yet

@sugaarK
Copy link
Member

sugaarK commented Aug 31, 2025

This should not be merged until we have an actual target PR from this manufacturer.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New manufacturer Add manufacturer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants