Add JHEH743PRO

[haslinghuis]

Checklist

• passed schematics review
• passed hardware samples testing
• follows guidelines
• follows connector standards
• flight tested
• comments/issues resolved

Summary by CodeRabbit

• New Features
  • Added support for JHEH743PRO (STM32H743) flight controller.
  • Built‑in support for ICM42688P accel/gyro, DPS310 barometer, MAX7456 OSD, and onboard flash Blackbox.
  • Supports up to 8 motors, addressable LED strip, multiple UARTs, I2C and SPI peripherals, ADC inputs and beeper.
  • Includes board‑tuned defaults for gyro alignment, current/voltage sensors, SPI/IO mappings and runtime presets.

[coderabbitai]

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a new public Betaflight board configuration header for the STM32H743-based JHEH743PRO, declaring MCU/board IDs, enabled sensors/peripherals, pin/timer/DMA mappings, SPI/I2C/UART/ADC assignments, default runtime settings, and gyro alignment macros.

Changes

Cohort / File(s)

Summary

Board config addition configs/JHEH743PRO/config.h

New public header defining FC_TARGET_MCU, BOARD_NAME, MANUFACTURER_ID; enables sensors/peripherals (ACC, ACC_SPI_ICM42688P, GYRO, GYRO_SPI_ICM42688P, BARO BARO_DPS310, FLASH FLASH_W25N01G, MAX7456, GYRO_CLKIN); maps motor pins (MOTOR1–MOTOR8), LED_STRIP_PIN, LED0/LED1, UART1–UART8 TX/RX, I2C1/I2C2 SCL/SDA, SPI1–SPI4 SCK/SDI/SDO, ADC pins, PINIO pins, FLASH/MAX7456 CS; defines TIMER_PIN_MAPPING, DMA options, I2C instances for MAG/BARO, default runtime settings (blackbox device, gyro usage, meter sources/scales, beeper invert), SPI instance assignments, PINIO box/config values, and gyro alignment (GYRO_1/GYRO_2).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add HAKRCH743 #757 — Adds another STM32H743 board config header with largely matching public macros and pin/SPI/I2C/timer/DMA settings.
• Add HWH7 (STM32H743) config – initial #893 — Adds an STM32H743 board configuration header defining similar MCU, sensor flags, and peripheral mappings.
• Add New Target DAKEFPVH743Pro #793 — Adds a STM32H743 board config header with overlapping macros for sensors, pin mappings, and gyro alignment.

Suggested reviewers

• ot0tot
• nerdCopter
• blckmn

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is incomplete compared to the required template structure. While the checklist section is properly filled out with appropriate checkbox selections, the description is missing substantial sections including the mandatory review information, hardware compliance requirements explanation, and the housekeeping section that contains important instructions. The template explicitly instructs to "Replace this text with details of your own," but the author provided only the bare checklist without any additional context or details about the board configuration being added. This represents a largely stripped-down version of the template rather than a properly completed submission.	The author should expand the pull request description to include all required sections from the template: the mandatory review information section, the hardware compliance requirements section, a housekeeping acknowledgment confirming the PR is from a custom branch, and importantly, a detailed explanation of what the JHEH743PRO board is, what configuration is being added, and relevant technical details. The checklist structure should be retained with the current selections, but complemented by these additional required sections and details.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "Add JHEH743PRO" is concise, clear, and directly reflects the main change in the changeset — adding a new Betaflight board configuration header for the JHEH743PRO board. The title is specific enough to convey meaningful information about the changeset without being vague, overly broad, or misleading. It clearly summarizes the primary change from the developer's perspective.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

configs/JHEH743PRO/config.h (3)

98-100: Note: PA15 as FLASH CS may disable full JTAG; ensure SWD-only is acceptable.

Using PA15 for CS is common but precludes JTAG on production units. Just confirm SWD is the intended debug mode.

---

123-127: DMA option set includes TIMUP5 but no TIM5 outputs are mapped; consider pruning or adding TIMUP2 if needed.

• Motors use TIM2 and TIM3; LED uses TIM1. Defining TIMUP5_DMA_OPT looks unused.
• If you ran into DMA stream conflicts on TIM2/TIM3, document them; otherwise, drop unused opts to reduce confusion.

---

131-138: Defaults OK; please confirm meter scales and beeper inversion from hardware measurements.

• CURRENT/VOLTAGE scales (170/110) are common starting points but benefit from calibration.
• BEEPER_INVERTED depends on the transistor stage; quick bench test recommended.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09e80da and 95f75db.

📒 Files selected for processing (1)

• configs/JHEH743PRO/config.h (1 hunks)

🧰 Additional context used

🧠 Learnings (14)

📓 Common learnings

Learnt from: haslinghuis
PR: betaflight/config#835
File: configs/HDZERO_HALO_MPU6000/config.h:44-56
Timestamp: 2025-07-14T16:16:56.822Z
Learning: For Betaflight board configurations of boards already in production, pin assignments in config.h files reflect the actual hardware design and cannot be changed, even if they present potential conflicts with debug interfaces. The configuration must match the physical board layout, not ideal software design preferences.

Learnt from: ot0tot
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-07-03T04:33:57.480Z
Learning: Always verify that the BOARD_NAME define in each config.h matches the directory name it resides in (e.g., configs/AXISFLYINGF7AIO/config.h must have #define BOARD_NAME AXISFLYINGF7AIO). This check is required for all Betaflight board configuration reviews.

Learnt from: ot0tot
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-07-03T04:33:57.480Z
Learning: Always verify that the `BOARD_NAME` define in config.h files exactly matches the directory name where the config file is located. For example, if the config file is in configs/AXISFLYINGF7AIO/config.h, then the BOARD_NAME should be defined as "AXISFLYINGF7AIO". This ensures proper board identification and configuration loading in Betaflight.

📚 Learning: 2025-07-14T16:16:56.822Z

Learnt from: haslinghuis
PR: betaflight/config#835
File: configs/HDZERO_HALO_MPU6000/config.h:44-56
Timestamp: 2025-07-14T16:16:56.822Z
Learning: For Betaflight board configurations of boards already in production, pin assignments in config.h files reflect the actual hardware design and cannot be changed, even if they present potential conflicts with debug interfaces. The configuration must match the physical board layout, not ideal software design preferences.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-07-03T04:33:57.480Z

Learnt from: ot0tot
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-07-03T04:33:57.480Z
Learning: Always verify that the BOARD_NAME define in each config.h matches the directory name it resides in (e.g., configs/AXISFLYINGF7AIO/config.h must have #define BOARD_NAME AXISFLYINGF7AIO). This check is required for all Betaflight board configuration reviews.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-07-03T04:33:57.480Z

Learnt from: ot0tot
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-07-03T04:33:57.480Z
Learning: Always verify that the `BOARD_NAME` define in config.h files exactly matches the directory name where the config file is located. For example, if the config file is in configs/AXISFLYINGF7AIO/config.h, then the BOARD_NAME should be defined as "AXISFLYINGF7AIO". This ensures proper board identification and configuration loading in Betaflight.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-06-23T18:43:31.746Z

Learnt from: haslinghuis
PR: betaflight/config#822
File: configs/AXISFLYINGH7MINI/config.h:29-37
Timestamp: 2025-06-23T18:43:31.746Z
Learning: In Betaflight configuration files, feature enablement macros like USE_MAG are build options that can be controlled at compile time, while hardware instance definitions like MAG_I2C_INSTANCE are predefined in board configurations to assist with hardware mapping when those features are enabled at build time.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-06-02T16:16:20.197Z

Learnt from: haslinghuis
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-06-02T16:16:20.197Z
Learning: In STM32F405-based flight controller configurations, timer pin mappings must be carefully analyzed for DMA stream conflicts, especially between motor timers, LED strip timers, and SPI DMA assignments. Changes to TIMER_PIN_MAPPING should include verification that all required peripherals (motors, LED strip, blackbox SPI) can coexist without DMA conflicts.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-08-28T20:45:36.652Z

Learnt from: haslinghuis
PR: betaflight/config#888
File: configs/ZEX_ATHENA_MINI/config.h:0-0
Timestamp: 2025-08-28T20:45:36.652Z
Learning: In STM32H743 Betaflight configurations, PA15 maps to TIM2_CH1 (timer index 2) as defined in timer_stm32h7xx.c. When used for GYRO_CLKIN functionality, it's recommended to use the macro name GYRO_1_CLKIN_PIN in TIMER_PIN_MAPPING for consistency with other pin definitions.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-08-28T20:45:36.652Z

Learnt from: haslinghuis
PR: betaflight/config#888
File: configs/ZEX_ATHENA_MINI/config.h:0-0
Timestamp: 2025-08-28T20:45:36.652Z
Learning: In STM32H743 Betaflight configurations, PB0 can use multiple timer options including TIM1_CH2N, TIM3_CH3, and TIM8_CH2N as defined in timer_stm32h7xx.c. For CAMERA_CONTROL_PIN assignments, TIM3_CH3 (timer index 3) is the appropriate choice.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-09-01T19:58:52.049Z

Learnt from: haslinghuis
PR: betaflight/config#881
File: configs/GEPRC_TAKER_H743MINI/config.h:86-99
Timestamp: 2025-09-01T19:58:52.049Z
Learning: For STM32H743 PB0 in Betaflight, there are three timer options: TIM1_CH2N, TIM3_CH3, and TIM8_CH2N. Only TIM3_CH3 (timer index 2) is suitable for GYRO_CLKIN as the other two are complementary (N) channels. This is confirmed in timer_stm32h7xx.c.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-08-20T02:54:58.596Z

Learnt from: ot0tot
PR: betaflight/config#872
File: configs/HGLRCH743/config.h:82-83
Timestamp: 2025-08-20T02:54:58.596Z
Learning: For Betaflight board configuration reviews, the definitive source for validating UART pin assignments is the serial_uart_{platform}.c file in the Betaflight codebase (e.g., serial_uart_stm32h7xx.c for STM32H7xx platforms), not generic MCU datasheets. These files contain the exact pin mappings that Betaflight supports for each UART peripheral.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-09-01T19:58:52.049Z

Learnt from: haslinghuis
PR: betaflight/config#881
File: configs/GEPRC_TAKER_H743MINI/config.h:86-99
Timestamp: 2025-09-01T19:58:52.049Z
Learning: For STM32H743 in Betaflight, PB0 has multiple timer options but only timer index 2 provides a non-complementary output suitable for GYRO_CLKIN functionality. The other timer options for PB0 are N channels (complementary outputs) which are not appropriate for CLKIN usage.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-05-31T17:01:39.423Z

Learnt from: haslinghuis
PR: betaflight/config#798
File: configs/FURYF4OSD/config.h:88-88
Timestamp: 2025-05-31T17:01:39.423Z
Learning: For STM32F4xx platforms, PB1 pin timer definitions are:
1 = DEF_TIM(TIM1, CH3N, PB1, 0, 0)
2 = DEF_TIM(TIM3, CH4, PB1, 0, 0) 
3 = DEF_TIM(TIM8, CH3N, PB1, 0, 0)
Timer instance 2 (TIM3, CH4) is the correct mapping for PB1 motor control on STM32F4xx platforms as defined in src/platform/STM32/timer_stm32f4xx.c

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-08-21T11:11:19.213Z

Learnt from: haslinghuis
PR: betaflight/config#870
File: configs/ZEX_ATHENA_STD_PRO/config.h:54-55
Timestamp: 2025-08-21T11:11:19.213Z
Learning: For STM32H743 in Betaflight, UART4 can use PB8 (UART4_RX) and PB9 (UART4_TX) with GPIO_AF8_UART4, as confirmed in the official Betaflight codebase at src/platform/STM32/serial_uart_stm32h7xx.c. This is a valid pin mapping despite what some generic STM32 documentation might suggest.

Applied to files:

• configs/JHEH743PRO/config.h

📚 Learning: 2025-07-14T15:41:14.364Z

Learnt from: ot0tot
PR: betaflight/config#834
File: configs/RADIOLINKF405/config.h:79-88
Timestamp: 2025-07-14T15:41:14.364Z
Learning: In STM32F405 configurations, PB1 typically maps to TIM3_CH4 and PC9 typically maps to TIM8_CH4. These are different timers and do not share DMA resources, so there is no conflict when both pins are used simultaneously (e.g., PB1 for LED_STRIP and PC9 for MOTOR4).

Applied to files:

• configs/JHEH743PRO/config.h

🔇 Additional comments (7)

configs/JHEH743PRO/config.h (7)

26-28: BOARD_NAME matches directory name; good.

JHEH743PRO in the define matches configs/JHEH743PRO/. Manufacturer ID looks fine (4 chars).

---

101-108: Both gyros share the same CLKIN (PD12); confirm the PCB ties both CLKINs together.

This is fine if the clock net is shared on the board. If not, set only the present one(s).

---

128-130: MAG_I2C_INSTANCE/BARO_I2C_INSTANCE without USE_MAG is fine.

Board-level hints are helpful even when feature macros are compile-time selected.

---

144-147: Gyro alignments: verify orientations match the silkscreen arrow(s).

Wrong alignment will cause attitude errors; quick hover test or sensor tab check recommended.

---

78-90: Incorrect — PB2 is a valid SPI3_SDO (MOSI) pin in this codebase

Repository search shows many H7 configs set SPI3_SDO_PIN = PB2 (e.g., configs/JHEH743_HD/config.h, configs/JHEH743PRO/config.h, configs/TMOTORH743/config.h, configs/MAMBAH743/config.h), so PB2 is an accepted mapping here and no platform change is required.

Likely an incorrect or invalid review comment.

---

53-68: Confirm UART4 PD0/PD1 and UART5 PC12 are present in serial_uart_stm32h7xx.c
fd search couldn't locate serial_uart_stm32h7xx.c (searched 'src'); many configs (including configs/JHEH743PRO) define UART4_TX=PD1 / UART4_RX=PD0 and UART5_TX=PC12 — verify those mappings exist in src/platform/STM32/serial_uart_stm32h7xx.c and update this config to use only pins listed there if they do not.

---

111-121: Confirm PD12 timer mapping for GYRO_CLKIN

• configs/JHEH743PRO sets GYRO_1_CLKIN_PIN / GYRO_2_CLKIN_PIN = PD12 and has TIMER_PIN_MAP( 9, PD12, 1, -1 ). (configs/JHEH743PRO/config.h:103,107,121)
• timer_stm32h7xx.c was not found by the verification script; many H7 configs treat PD12 as TIM4_CH1 (PWM-capable). Confirm timer_stm32h7xx.c maps PD12 to a PWM-capable channel (e.g., TIM4_CH1) or update the TIMER_PIN_MAPPING accordingly.