Skip to content

Conversation

@Michael-Oxbot
Copy link
Contributor

@Michael-Oxbot Michael-Oxbot commented Sep 25, 2025

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Official support for the OXBOTF43512AAIO (AT32F435G) flight controller.
    • Enables onboard gyro/accelerometer, barometer, and flash-based Blackbox.
    • Preconfigured motor outputs, UARTs (MSP and SerialRX), SPI/I2C, ADC, LEDs, beeper, and LED strip.
    • Defaults: DShot with telemetry, ADC current/voltage meters (with scale), gyro alignment, timer/clock and peripheral mappings for plug-and-play setup.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Walkthrough

Adds a new platform configuration header for an AT32F435G-based board (OXBOTF43512AAIO) that defines MCU/board identifiers, enabled peripherals and sensor/flash types, comprehensive pin and timer mappings, DMA/ADC/clock constants, and default telemetry/Blackbox/metering/UART assignments (all via preprocessor macros).

Changes

Cohort / File(s) Summary of Changes
AT32F435G board config addition
configs/OXBOTF43512AAIO/config.h
New header adding macros for FC target MCU, board/manufacturer IDs, enabled features (ACC, GYRO, BARO, FLASH), sensor/flash selections (ICM42688P, W25Q128FV, DPS310), full pin mappings (motors, UARTs, I2C, SPI, ADC, LEDs, beeper, gyro CS/INT/CLKIN), TIMER_PIN_MAPPING, ADC/DMA/clock constants, gyro/flash SPI instances, default Blackbox/current/voltage/DSHOT settings, MSP and SERIALRX UART mappings.

Sequence Diagram(s)

(omitted — change is configuration-only, no runtime control-flow modified)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • haslinghuis
  • ot0tot
  • nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only lists a partial checklist without replacing or completing any of the narrative sections required by the repository template. It lacks a summary of the new flight controller target, narrative context, and evidence of adherence to hardware compliance and mandatory review guidelines. As a result, essential information about the purpose, scope, and review status of the OXBOTF43512AAIO changes is missing. Please update the description to include a concise summary of the OXBOTF43512AAIO target and its purpose and to replace all template placeholder text with relevant details. The description should explain compliance with manufacturer design guidelines and connector standards, and clarify which schematic reviews, hardware tests, and Betaflight team reviews have been completed or are still pending. Additionally, confirm the status of the unchecked checklist items and address any remaining comments to fulfill the repository’s Pull-Request requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title concisely and accurately describes the main change by indicating that a new OXBOTF43512AAIO target is being added, making it clear and specific for reviewers scanning the history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ot0tot
Copy link
Contributor

ot0tot commented Sep 26, 2025

Config looks good. Have you sent out hardware samples?

@Michael-Oxbot
Copy link
Contributor Author

Config looks good. Have you sent out hardware samples?

Thank you for the review. We'll send hardware samples soon.

@blckmn blckmn merged commit c70a9c1 into betaflight:master Oct 11, 2025
2 checks passed
This was referenced Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants