-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSE article for ZFP #1961
Add SSE article for ZFP #1961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the article is it reads well. I think this is a good addition to BSSw.io. It would make a good featured blog article.
@bartlettroscoe thanks for the positive feedback 🎉 . That said, I am sheepish about merging myself because prior to ECP end, I would defer to final decision from @rinkug or maybe @bernhold or @curfman. Should I be wearinig a new thinking cap now? |
@markcmiller86, that is a good question. But until we define the updated process, we should not assume that a positive review by a BSSw.io editorial member is sufficient for merging an article. I think we should follow the checklist process above. |
@betterscientificsoftware/bssw-maint this is ready for publication |
@markcmiller86 : Thanks so much for this nice article. Minor edits - The deck text should probably change and maybe the intro could be smoother. Since there are two authors, the "I" can sound ambiguous? I can help with it pending David's feedback. @bernhold: This is an short article, kind of interview style. Can you take a look and let me know what needs to change. |
We don't need every occurrence of zfp to link to the website. That becomes distracting.
Hi @markcmiller86, I'm editing this for publication later this week. I've taken the liberty of restructuring it to be more in the format of an interview. All I really did was to intersperse your questions into appropriate places in Peter's answers. And I moved one of Peter's paragraphs from one section (question) to another where it made more sense. Can you please give this version a quick scan and confirm that I haven't messed things up (too much)? Thanks |
@bernhold LGTM. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I have only a couple of minor corrections.
minor edits
added brief intro
Add a line to intro paragraph
undo extra sentence
This is the promised article about software sustainability engineering on ZFP. @lindstro reviewed and approved earlier today though I will leave open the possibility that a few small changes may still be needed before publication on bssw.io.
Be sure to select
main
as thebase
branch above as the target for this PR.Provide a general summary of your changes in the title above.
Fill in the below Description section with minimal text describing the changes/new contributions in this PR and replace
<...>
as appropriate.Any checklist items that do not apply can be striken out by adding
~~
to the beginning and end of the checklist item as* ~~[] <checklist-item>~~
.Also, remove the strikeout markers
~~
for the wikize_refs.py checklist items if using formal citations for bssw.io contributions.Description
EB Member: @rinkug
PR checklist for files displayed on bssw.io site
@mention
the BSSw.io editorial board member@<eb-member-id>
in Description above assigned to shepherd your PR.[ ] [Author] Add the<issue-id>
in the Description above for the associated GitHub Issue.[ ] [Author] Ensure.wikize_refs.py -i <base>.md
is run and commit (if using wikize_refs.py)*.md
file(s) as rendered in GitHub for this PR.<eb-member-id>
.<pr-author-id>
.content: <content-type>
for the type of contribution.Content Development
(see Content Development).*.md
file(s) (setPublish: yes
).preview
(so PR branch will be merged to 'preview' branch and watch for possible merge failures).[ ] [Author] Ensurewikize_refs.py -i <base>.md
is run and commit (if using wikize_refs.py).@betterscientificsoftware/bssw-maint
(BSSw Maint) asking to carry out final publication steps.NOTE:
@betterscientificsoftware/bssw-maint
team (hint: type@
,b
,s
,s
,w
,-
,m
to auto-complete to@betterscientificsoftware/bssw-maint
).