Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Base #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update Base #14

wants to merge 7 commits into from

Conversation

avgcod
Copy link

@avgcod avgcod commented Mar 14, 2024

Update .NET to 8 since 6 and 7 will be EOL this year anyway. Update NuGet packages.
Clean up non Fody warnings.
Remove Fody.

Updated the pull request comment due to not separating the branches properly.

@avgcod
Copy link
Author

avgcod commented Mar 14, 2024

My Remove Fody change literally just removes the Fody package. Nothing seems to break with quick testing so not sure if maybe the uses were already removed or not. If the PropertyChanged methods are needed we could easily add the CommunityToolkit.MVVM as a light weight alternative to hand rolling them.
This is literally my first time doing pull requests and I am new to git so if I am doing this wrong please let me know.
Already noticing my local branching is not being mirrored here but hopefully these changes are small enough to not hold things up.

avgcod added 4 commits March 15, 2024 12:10
…lease to InitLibrary and DestroyLibrary. See https://github.com/sungaila/PDFtoImage for an up to date usage of PDFium.dll. Changes made have been from here and will likely continue to be pulled from here where the usages do not diverge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant