Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation:
From my understanding the last
if()
is duplicate/redundant/unreachable, because whenever the secondif()
evaluates to true, the firstif()
already evaluated to true before.In general this was spotted by GitHub CodeQL in my fork on GitHub, but as as "redundant null check due to previous dereference" (because
strtoul()
never sets*eptr
toNULL
).The current code was introduced with commit b481111; the first
if()
was previously:I'm still not really sure why the previous
*eptr
check was changed from\0
to\n
in the commit mentioned above…please cross-check before accepting this pull request.