Skip to content

[ENH] use snippets to link to definitions via tooltips #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Dec 12, 2024

this is me trying things out, see if this is a viable option

image

@Remi-Gau
Copy link
Collaborator Author

@tsalo @Lestropie

demo

https://www.dropbox.com/scl/fi/h1vmjihby032jdqismplg/Screencast-from-12-12-2024-15-45-05.webm?rlkey=rgm5qkjvlvtuj18e3fclchl11&dl=0

@effigies
maybe also useful to have consistent set of links to external things across all pages:

$ grep -rni https://www.json.org/json-en.html src

src/modality-agnostic-files.md:549:[object]: https://www.json.org/json-en.html
src/modality-specific-files/genetic-descriptor.md:137:[object]: https://www.json.org/json-en.html
src/modality-specific-files/motion.md:240:[object]: https://www.json.org/json-en.html
src/derivatives/common-data-types.md:343:[object]: https://www.json.org/json-en.html
src/schema/objects/metadata.yaml:3360:    [Object](https://www.json.org/json-en.html)
src/common-principles.md:481:    [JSON object](https://www.json.org/json-en.html) described below; and
src/common-principles.md:515:in the form of a JSON [object](https://www.json.org/json-en.html)
src/appendices/hed.md:58:The JSON sidecar provides a [JSON object](https://www.json.org/json-en.html) of annotations for these categorical values.

Though I wonder how this part would play with the PDF generation.

@effigies
Copy link
Collaborator

IMO links are less useful in a PDF, so if this only affects the HTML spec, that seems fine.

@Remi-Gau
Copy link
Collaborator Author

The tool tip part would only be the html part. The second part about link summary would likely affect the pdf.
Should try to confirm.

@Remi-Gau Remi-Gau changed the title [ENH] use snippets to link to definitions [ENH] use snippets to link to definitions via tooltips Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (0a8f910) to head (251d812).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2005   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files          17       17           
  Lines        1504     1504           
=======================================
  Hits         1240     1240           
  Misses        264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Extensive use of definition hyperlinks
2 participants