PROMO-933 add bulk coupon code generation #970
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YevenLourance
force-pushed
the
PROMO-933
branch
5 times, most recently
from
b2368fc to
281881b
Compare
BC-SEven
reviewed
Jun 5, 2025
reference/promotions.v3.yml
Outdated
| - batch_size | ||
| type: object | ||
| properties: | ||
| prefix: |
There was a problem hiding this comment.
Lets add a minLength, maxLength and pattern to this property.
BC-SEven
reviewed
Jun 5, 2025
reference/promotions.v3.yml
Outdated
| type: string | ||
| description: A prefix to add to the generated codes. | ||
| example: 'PROMO' | ||
| suffix: |
There was a problem hiding this comment.
Same here. A minLength, maxLength and pattern could be helpful here
BC-SEven
reviewed
Jun 5, 2025
reference/promotions.v3.yml
Outdated
Comment on lines
231
to
236
| batch_size: | ||
| type: integer | ||
| description: The number of coupon codes to generate in each batch. The maximum value is 250. | ||
| example: 5 | ||
| max_uses: | ||
| type: integer | ||
| description: The maximum number of times each coupon code can be used. The default value is 0, which represents unlimited uses. | ||
| example: 10 | ||
| max_uses_per_customer: |
There was a problem hiding this comment.
We can define a minimum and maximum for these values
BC-SEven
reviewed
Jun 5, 2025
reference/promotions.v3.yml
Outdated
| example: 5 | ||
| max_uses: | ||
| type: integer | ||
| description: The maximum number of times each coupon code can be used. The default value is 0, which represents unlimited uses. |
There was a problem hiding this comment.
Considering the use case for batch creation of codes would a default of 1 make more sense?
reference/promotions.v3.yml
Outdated
|
|
||
| **Note:** | ||
| * batch_size is limited to 250 codes per request for first version. If batch_size is not an integer or larger than 250, it will return a 400 error code. | ||
| * The default rate limit for this endpoint is 40 concurrent requests. |
There was a problem hiding this comment.
should we start with small number first ?
Suggested change
| * The default rate limit for this endpoint is 40 concurrent requests. | |
| * The default rate limit for this endpoint is 10 concurrent requests. |
There was a problem hiding this comment.
Maybe lets just not expose what our concurrent limits are? Since these are dynamic, probably not very useful to add a hard number in the docs
YevenLourance
force-pushed
the
PROMO-933
branch
3 times, most recently
from
64da408 to
05c6903
Compare
YevenLourance
force-pushed
the
PROMO-933
branch
5 times, most recently
from
0aba0df to
4c36f48
Compare
YevenLourance
force-pushed
the
PROMO-933
branch
3 times, most recently
from
92348bd to
f64b1fe
Compare
add bulk coupon code generation
add max and min length and change based on feedback
…e settings to response remove prefix and suffix and add more code settings to response change to capital letters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add bulk coupon code generation
PROMO-933
What changed?
Release notes draft
in progress
Anything else?
in progress
ping {names}