add options to NewWithDefaults, update bool #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@emar-kar Can you rebase and fix the conflicts for this? |
Contributor
Author
|
@bigkevmcd yeah, sure, will do today, a little bit later |
emar-kar
force-pushed
the
le/add-opts-nwd
branch
from
1ddcebf to
bf54038
Compare
Owner
|
I'm not so sure about this change. While I appreciate the intent, this behaviour is different from the Python ConfigParser? https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.getboolean Having said that, it doesn't seem to be a massive deviation, let me think about this a bit more. |
Owner
|
The |
bigkevmcd
reviewed
Mar 11, 2025
emar-kar
force-pushed
the
le/add-opts-nwd
branch
from
bf54038 to
5e1dec0
Compare
bigkevmcd
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds options into
NewWithDefaultsfunction and makes boolean check case insensitive