Skip to content

[codex] add workflow preset visual item matrix contract - #16

Merged
bigsmartben merged 1 commit into
mainfrom
codex/add-visual-item-matrix-contract-pr
Jun 22, 2026
Merged

[codex] add workflow preset visual item matrix contract#16
bigsmartben merged 1 commit into
mainfrom
codex/add-visual-item-matrix-contract-pr

Conversation

@bigsmartben

@bigsmartben bigsmartben commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Description

Adds the workflow preset Visual Item Matrix contract to the integrated spec-kit repository and keeps the integration checks aligned with the bundled preset manifest.

This updates:

  • presets/workflow-preset schema, docs, commands, templates, validator, and contract tests
  • presets/catalog.json bundled template count
  • .github/workflows/community-smoke.yml and .github/workflows/workflow-preset-integration.yml so Actions verify the new bundled schema file
  • tests/test_presets.py assertions for the workflow verification lists

Testing

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest
  • Tested with a sample project (if applicable)

Additional validation run:

  • uv sync --extra test - OK
  • uvx ruff check src/ - OK
  • uv run pytest tests/integrations/test_cli.py -k "community_extensions_and_workflow_preset_auto_installed or workflow_preset_registers" -v - OK, 2 passed
  • uv run pytest tests/test_presets.py -k "workflow_preset or bundled_preset" -v - OK, 9 passed
  • From presets/workflow-preset: python -m unittest tests/test_preset_contract.py - OK, 133 tests, 2 skipped
  • git diff --check - OK
  • python -c "import json; json.load(open('presets/catalog.json', encoding='utf-8')); print('Valid JSON')" - OK

Full local uv run pytest was attempted on Windows: 3771 passed, 165 skipped, 10 failed. The failures were local environment issues unrelated to this change: symlink creation blocked by WinError 1314 and two default-GBK fixture reads. CI should exercise the workflow-defined Linux/Windows matrix.

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Used Codex to inspect the integrated repository workflows, update the PR branch, run local validation, and prepare this PR.

@bigsmartben
bigsmartben force-pushed the codex/add-visual-item-matrix-contract-pr branch from 3366038 to 3454744 Compare June 22, 2026 09:49
@bigsmartben
bigsmartben marked this pull request as ready for review June 22, 2026 10:07
@bigsmartben
bigsmartben merged commit a930a88 into main Jun 22, 2026
12 checks passed
@bigsmartben
bigsmartben deleted the codex/add-visual-item-matrix-contract-pr branch June 22, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant