refactor(workflow-preset): make UI/UX specification template-owned - #70
Conversation
Assisted-by: Codex (model: GPT-5, autonomous)
48a2c14 to
be1e554
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be1e554b39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Set `Gate Status: PASS` only when every applicable readiness item is checked and `Blocking Items: none`. Otherwise set `Gate Status: BLOCKED` and list each unchecked readiness item that prevents behavior projection or downstream planning. | ||
|
|
||
| Unchecked readiness items that prevent behavior projection or downstream planning are blocking items. Do not proceed to `/speckit.plan`. Requirement ambiguity returns to `/speckit.clarify` or `/speckit.specify` to resolve missing requirements before planning. Provider evidence readiness blockers return to the external intake extension, not `/speckit.clarify`. | ||
| Unchecked readiness items that prevent downstream planning return to `/speckit.clarify` or `/speckit.specify`. Do not repair requirements inside the checklist command and do not proceed to `/speckit.plan`. |
There was a problem hiding this comment.
Remove provider gates from the composed checklist flow
When this wrap command is resolved against the bundled core, {CORE_TEMPLATE} still inserts templates/commands/checklist.md, whose lines 61-99 require a separate visual domain and explicitly define provider-evidence blockers routed to intake; the wrapped clarify command likewise preserves that route at templates/commands/clarify.md:77-84 and 247-248. Consequently, UI features can still produce the source-specific blockers this change claims to remove, contradicting this new clarify/specify-only routing. Reconcile those core instructions or use a replacement that actually implements the source-agnostic contract.
AGENTS.md reference: presets/workflow-preset/AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
| "UI-", | ||
| "UX-", | ||
| "UI/UX Requirement ID", |
There was a problem hiding this comment.
Match receipt evidence to the handed-off requirement
For a UI/UX handoff referencing UI-001, this marker-only check accepts evidence for an unrelated requirement such as UI-999; it even accepts generic text like UI-component tests passed or UI/UX Requirement ID not verified. validate_receipt_structure() can therefore approve completion without evidence for the requirement actually assigned in the handoff. Extract the concrete UI-[0-9]+/UX-[0-9]+ IDs from the handoff and require the receipt to reference the same IDs.
Useful? React with 👍 / 👎.
Description
Refactors
workflow-presetso UI/UX specification is source-agnostic and its durable structure is owned by templates instead of command prose.spec-templatewith stableUI-###andUX-###requirementsRequired,Not Applicable,Unknown) separate from Readiness (Ready,Blocked)extensions/intake/unchangedThis prevents
/speckit.specifyand/speckit.checklistfrom becoming coupled to a particular design source or extraction workflow. Users can provide confirmed product requirements from any source while downstream stages consume stable UI/UX requirement IDs and readiness decisions.Closes #63
Testing
uv run specify --helpuv sync && uv run pytestFocused validation:
presets/workflow-preset:141 passed, 2 skippedtests/test_presets.py:331 passed2 passed, 86 deselectedgit diff --check: passedThe full repository suite was attempted and stopped at approximately 34% after repeated failures in shared Markdown integration tests. The reproduced failure expects
spec.md (FEATURE_SPEC) is required, while the current core checklist template renders`spec.md` (`FEATURE_SPEC`) is required. The failure occurs across unrelated integrations and is outside this PR's changed files.Preset / Extension Contract
spec-templateand the behavior checklist template own stable Markdown structures; existing implement schemas and validators retain machine-readable handoff contracts.tests/test_presets.pyand the workflow-preset CLI integration tests.141 passed, 2 skipped; preset/catalog regression331 passed; workflow-preset CLI integration2 passed.Community Catalog Submission
AI Disclosure
Implemented, tested, and posted on behalf of @bigsmartben by Codex (model: GPT-5, autonomous).