Update workflow-preset to v3.0.0 - #78
Conversation
Assisted-by: GitHub Actions (autonomous)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c95f423e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: workflow-preset | ||
| name: Workflow Preset | ||
| version: 2.0.0 | ||
| version: 3.0.0 |
There was a problem hiding this comment.
Update the integration smoke test for the removed override
When .github/workflows/workflow-preset-integration.yml runs its external-release-install job for version 3.0.0, line 124 still executes test -f .specify/presets/workflow-preset/commands/speckit.implement.md. This release deliberately removes that file, so the step exits under set -e and every external-release validation fails before it can verify the core implementation command. Change the workflow to assert that the preset-owned file is absent while retaining the existing check for the generated core speckit-implement skill.
AGENTS.md reference: presets/workflow-preset/AGENTS.md:L19-L20
Useful? React with 👍 / 👎.
Sync the immutable v3.0.0 Release snapshot, remove the preset-owned Implement override, preserve Tasks final Code Review, and validate Core Implement ownership across bundled and external installs. Assisted-by: OpenAI Codex (model: GPT-5, autonomous)
Combine the release workflow's generated snapshot commit with the full issue #30 integration and validation changes. Assisted-by: OpenAI Codex (model: GPT-5, autonomous) # Conflicts: # presets/catalog.community.json # presets/catalog.json
|
Integration update pushed at commit Changes include the immutable v3.0.0 Release snapshot and manifest, catalog source/SHA metadata, removal of the preset-owned Implement command, Core Implement SHA preservation checks, final Tasks Code Review coverage, and updated community smoke/documentation. Validation: Release manifest 42/42 file hashes matched; bundled and Posted on behalf of @bigsmartben by OpenAI Codex (model: GPT-5, autonomous). |
Summary
Test Plan