-
Notifications
You must be signed in to change notification settings - Fork 1
Added delete note functionality with confirmation modal #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JAbelP
wants to merge
15
commits into
master
Choose a base branch
from
001-Frontend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JAbelP
commented
Nov 27, 2025
- Backend: Added DELETE /api/notes/{path} endpoint that deletes note from filesystem and index
- Frontend: Added deleteNote() API function with proper error handling
- Frontend: Created DeleteConfirmationDialog component for user confirmation
- Frontend: Integrated delete flow into MainApp with toast notifications
- Improved API error handling to support both standard and FastAPI error formats
- Updated GITSUMMARY.md with implementation details
001 obsidian docs viewer
Frontend Implementation: Skeleton Animations, Folder Support, and UI Improvements
- Backend: Added DELETE /api/notes/{path} endpoint that deletes note from filesystem and index
- Frontend: Added deleteNote() API function with proper error handling
- Frontend: Created DeleteConfirmationDialog component for user confirmation
- Frontend: Integrated delete flow into MainApp with toast notifications
- Improved API error handling to support both standard and FastAPI error formats
- Updated GITSUMMARY.md with implementation details
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
…ate delete feature - Resolved APIException constructor signature change in api.ts - Merged GraphView and isDemoMode functionality with delete handlers - Added onDelete handler to NoteViewer with demo mode check - Delete feature properly integrated with latest master changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.