Skip to content

ci: fix download reports on sonarqube #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/basic-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Archive lint report results
uses: actions/upload-artifact@v4
with:
name: lint-report.info
name: lint-report
path: reports

build:
Expand Down Expand Up @@ -50,14 +50,15 @@ jobs:
- run: npx nx test ngx-deploy-npm --configuration="ci"

- name: Set Node.js version based on .nvmrc
id: nvmrc
shell: bash
run: |
version=$(cat .nvmrc)
echo "Setting default value for node-version parameter: $version"
echo "NODE_VERSION=$version" >> $GITHUB_ENV
echo "$NODE_VERSION"
echo "node_version=$version" >> $GITHUB_OUTPUT
echo "$version"

- if: ${{ matrix.os == 'ubuntu-latest' && matrix.node-version == env.NODE_VERSION }}
- if: ${{ matrix.os == 'ubuntu-latest' && matrix.node-version == steps.nvmrc.outputs.node_version }}
name: Archive coverage report
uses: actions/upload-artifact@v4
with:
Expand Down
48 changes: 46 additions & 2 deletions .github/workflows/sonar-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,52 @@ jobs:
JSON.stringify(${{ github.event.workflow_run }}, null, 2)

# Download reports
- uses: ./.github/actions/download-coverage-report
- uses: ./.github/actions/download-lint-report
- name: 'Download reports'
uses: actions/github-script@v6
with:
script: |
async function downloadArtifact(artifactName) {
console.log(`Looking for artifact: ${artifactName}`);
let allArtifacts = await github.rest.actions.listWorkflowRunArtifacts({
owner: context.repo.owner,
repo: context.repo.repo,
run_id: context.payload.workflow_run.id,
});
console.log('Available artifacts:', allArtifacts.data.artifacts.map(a => a.name));

let matchArtifact = allArtifacts.data.artifacts.find((artifact) => {
return artifact.name === artifactName;
});

if (!matchArtifact) {
throw new Error(`Artifact "${artifactName}" not found!`);
}

let download = await github.rest.actions.downloadArtifact({
owner: context.repo.owner,
repo: context.repo.repo,
artifact_id: matchArtifact.id,
archive_format: 'zip',
});

let fs = require('fs');
fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/${artifactName}.zip`, Buffer.from(download.data));
return artifactName;
}

// Download both artifacts
await Promise.all([
downloadArtifact('ngx-deploy-npm-coverage-report'),
downloadArtifact('lint-report')
]);
- name: 'Extract reports'
run: |
# Extract coverage report
mkdir -p coverage/packages/ngx-deploy-npm
unzip ngx-deploy-npm-coverage-report.zip -d coverage/packages/ngx-deploy-npm
# Extract lint report
mkdir -p reports
unzip lint-report.zip -d reports

- name: SonarCloud Scan
uses: SonarSource/[email protected]
Expand Down
Loading