Draft
Conversation
7 tasks
Collaborator
Author
|
#1041 needs to be merged before the CI can pass. |
ColmTalbot
reviewed
Feb 18, 2026
Collaborator
ColmTalbot
left a comment
There was a problem hiding this comment.
- How do we want to handle the examples?
- For now I've left the examples that use other samplers but added an explicit error.
This looks good to me, neater than what we had before.
- How should the tests work if external samplers are installed?
- At the moment, they detect all available samplers, including any external samplers that are installed.
Probably, we should only test the ones we package.
It would be great if we can expose this test in some way that plugins can use it directly.
- One of the doc notebooks uses external samples, should these be installed for the entire CI or just the docs CI?
Yeah, I think we should have at least a few of those available, maybe in the full CI.
It might be worth changing which ones are used, restrict it to maintained, easy to install ones?
- Should we still provide sampler_requirements.txt?
I'm leaning to no, but could go either way.
| - pytorch | ||
| - pymc>=5.9 | ||
| - nessai | ||
| - ptmcmcsampler |
Collaborator
There was a problem hiding this comment.
There are probably other packages that can be removed from here, but I imagine it will be a pain to go through and figure out which.
a76f035 to
3d91722
Compare
Re-add proposal.py
3d91722 to
7fa0a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the external samplers for 3.0.
I see a few open questions:
sampler_requirements.txt?