Fix spin conversion error to avoid NaN#1052
Open
ThibeauWouters wants to merge 2 commits intobilby-dev:mainfrom
Open
Fix spin conversion error to avoid NaN#1052ThibeauWouters wants to merge 2 commits intobilby-dev:mainfrom
ThibeauWouters wants to merge 2 commits intobilby-dev:mainfrom
Conversation
Collaborator
|
I think Github actions were unhappy yesterday. I'm going to rebase and check that this works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1051
Essentially simply adds the try-except from the
elsebranch of the if-else block to theifbranch to check for zero spins that would cause division by zero. This fixes the problem described in the issue but might be a bit of a lazy solution so feedback welcome.Also added a test for this. The test succeeds but CI/CD fails, which I believe comes from other issues from the CI/CD?