BLD: update python versions for CI containers#1053
Conversation
|
I manually triggered the build job, assuming it works, I will add more recent python versions to the testing. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
I refactored the dockerfile specifcation/build a little so that there is a single dockerfile that accepts arguments. I also switched to use a multi-stage dockerfile that will improve caching efficiency, for example the ROQ data is its own stage so it will be shared across the different python versions for the container and will be persistently cached so we won't be downloading that data fresh every time. |
|
@ColmTalbot is there a way to test the Dockerfile builds? Or are those done by the CI? Also the Codecov is failing, I presume because of a -0.03% decrease. Is there a way to reduce the tolerance on that as I can see that failing a lot for small PRs that just add lines. |
The container build jobs can be manually triggered here for any branches on
Yeah, this is annoying, but I'm not sure how to loosen that tolerance currently. |
|
I think one could add a tolerance in |
|
I added a basic one that should at least not fail based on lines being randomly not covered. |
Our test environments are a bit behind, but I think our dependencies now support recent versions of python. I also removed build for py310.
We can continue to test with the existing image, but the pinned gwpy version is incompatible with python 3.10.
Numpy dropped 3.10 support a while ago.