Skip to content

BLD: update python versions for CI containers#1053

Merged
ColmTalbot merged 7 commits intomainfrom
update-container-versions
Feb 24, 2026
Merged

BLD: update python versions for CI containers#1053
ColmTalbot merged 7 commits intomainfrom
update-container-versions

Conversation

@ColmTalbot
Copy link
Collaborator

Our test environments are a bit behind, but I think our dependencies now support recent versions of python. I also removed build for py310.
We can continue to test with the existing image, but the pinned gwpy version is incompatible with python 3.10.
Numpy dropped 3.10 support a while ago.

@ColmTalbot
Copy link
Collaborator Author

I manually triggered the build job, assuming it works, I will add more recent python versions to the testing.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ColmTalbot
Copy link
Collaborator Author

I refactored the dockerfile specifcation/build a little so that there is a single dockerfile that accepts arguments.

I also switched to use a multi-stage dockerfile that will improve caching efficiency, for example the ROQ data is its own stage so it will be shared across the different python versions for the container and will be persistently cached so we won't be downloading that data fresh every time.

@ColmTalbot ColmTalbot requested a review from a team February 23, 2026 19:05
@GregoryAshton
Copy link
Collaborator

@ColmTalbot is there a way to test the Dockerfile builds? Or are those done by the CI?

Also the Codecov is failing, I presume because of a -0.03% decrease. Is there a way to reduce the tolerance on that as I can see that failing a lot for small PRs that just add lines.

@ColmTalbot
Copy link
Collaborator Author

is there a way to test the Dockerfile builds? Or are those done by the CI?

The container build jobs can be manually triggered here for any branches on bilby-dev (that's why I opened this here and not on my fork).
Also, I ran it a few times for this branch to get the containers for the updated python versions.
They will also run as a scheduled job, I think nightly.

Also the Codecov is failing, I presume because of a -0.03% decrease. Is there a way to reduce the tolerance on that as I can see that failing a lot for small PRs that just add lines.

Yeah, this is annoying, but I'm not sure how to loosen that tolerance currently.

@mj-will
Copy link
Collaborator

mj-will commented Feb 24, 2026

I think one could add a tolerance in codecov.yml: https://docs.codecov.com/docs/commit-status

@ColmTalbot
Copy link
Collaborator Author

I added a basic one that should at least not fail based on lines being randomly not covered.
We can add a more comprehensive version later.

@ColmTalbot ColmTalbot enabled auto-merge February 24, 2026 15:14
Copy link
Collaborator

@GregoryAshton GregoryAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColmTalbot ColmTalbot added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 0985f75 Feb 24, 2026
18 checks passed
@ColmTalbot ColmTalbot deleted the update-container-versions branch February 24, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants