Adding inject_glitch feature and example#1063
Open
narolaharsh wants to merge 11 commits intobilby-dev:mainfrom
Open
Adding inject_glitch feature and example#1063narolaharsh wants to merge 11 commits intobilby-dev:mainfrom
narolaharsh wants to merge 11 commits intobilby-dev:mainfrom
Conversation
Fix spelling mistakes
Time shift work in progress Time shifts fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature could be of use for various glitch-mitigation or effect of glithces on PE related simulations. Any feedback on furhter developement, relevance of the feature for Bilby welcome.
Specifically, adding the following method to the interferometer object. It injects a glitch at a user-specified SNR and user-specified onset time to the interferometer. A glitch waveform generator is not needed; an arbitrary timeseries can be rolled, scaled, and injected to the detector.
Also adding an example script in the usual sub-directory.
Comments from Colm on the previous PR (closed due to incorrect source branch).