Skip to content

[codex] Fix packaged MCP blocklist assets#1132

Merged
binaricat merged 1 commit into
mainfrom
codex/fix-packaged-mcp-command-blocklist
May 28, 2026
Merged

[codex] Fix packaged MCP blocklist assets#1132
binaricat merged 1 commit into
mainfrom
codex/fix-packaged-mcp-command-blocklist

Conversation

@binaricat
Copy link
Copy Markdown
Owner

Summary

  • unpack shared lib CommonJS and JSON assets alongside the unpacked MCP server
  • add a packaging config regression test for the MCP server shared dependencies

Root cause

The packaged MCP entrypoint runs from app.asar.unpacked/electron/mcp, but lib/commandBlocklist.cjs and its sibling commandBlocklist.json stayed inside app.asar. That made the MCP process exit during startup before Codex could finish the initialize handshake.

Fixes #1130.

Validation

  • npm run lint
  • npm test
  • npm run pack:dir
  • verified release/mac-arm64/Netcatty.app/Contents/Resources/app.asar.unpacked/lib/commandBlocklist.cjs exists
  • verified release/mac-arm64/Netcatty.app/Contents/Resources/app.asar.unpacked/lib/commandBlocklist.json exists
  • launched the packaged MCP entrypoint with a dummy port and confirmed it now reaches the expected connection failure instead of a missing-file crash

@binaricat binaricat marked this pull request as ready for review May 28, 2026 02:44
@binaricat
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@binaricat binaricat merged commit 2c716cd into main May 28, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codex获取MCP的主机列表获取不到

1 participant