Skip to content

Fix Mosh saved password prompt matching#999

Closed
binaricat wants to merge 2 commits into
mainfrom
codex/fix-989-mosh-password-prompts
Closed

Fix Mosh saved password prompt matching#999
binaricat wants to merge 2 commits into
mainfrom
codex/fix-989-mosh-password-prompts

Conversation

@binaricat
Copy link
Copy Markdown
Owner

Summary

  • align Mosh saved-password prompt detection with the SSH keyboard-interactive rules
  • support localized password prompts such as Chinese "密码:"
  • keep OTP/MFA prompts such as "One-time password:" from receiving the saved password
  • add Mosh handshake tests for both cases

Fixes #989.

Validation

  • node --test electron/bridges/terminalBridge.moshHandshakeSession.test.cjs electron/bridges/terminalBridge.bareMoshClient.test.cjs electron/bridges/sshAuthHelper.kbdInteractive.test.cjs
  • npx eslint electron/bridges/terminalBridge.cjs electron/bridges/terminalBridge.moshHandshakeSession.test.cjs (project config ignores these CJS files; no errors)
  • npm test

@binaricat
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a8693d3d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread electron/bridges/terminalBridge.cjs Outdated
@binaricat
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@binaricat
Copy link
Copy Markdown
Owner Author

根据 issue 作者后续反馈,这个 PR 的判断方向不对,先关闭;会基于新的复现原因另开 PR 处理。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: mosh协议的自动登录功能失效了

1 participant