Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal manager: Add a tooltip about mismatching types #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 7, 2025

I drafted something and I know it's ugly:

  • It assumes that __dynamicEnabled being false is always a consequence of type mismatch. (True for now, but not necessarily in the future.)
  • It doesn't update the tooltip if the user renames the source or sink widget after sending the data. (Minor glitch, but still...)

The latter would require connecting some distant signals, the former requires checking the reason for mismatch (i.e. comparing the signal types).

@ales-erjavec: is this a useful start or would you approach it differently?

@ajdapretnar: is the message OK?

Screenshot 2025-03-07 at 11 19 07

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (e9297c5) to head (76f3e74).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   76.47%   76.49%   +0.01%     
==========================================
  Files         102      102              
  Lines       21248    21257       +9     
==========================================
+ Hits        16249    16260      +11     
+ Misses       4999     4997       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ajdapretnar
Copy link
Contributor

I think the message is ok.

@ales-erjavec
Copy link
Collaborator

@ales-erjavec: is this a useful start or would you approach it differently?

It's fine.

@janezd janezd force-pushed the red-links-tooltip branch 2 times, most recently from dca210a to 48e5a4d Compare March 15, 2025 18:00
@janezd janezd force-pushed the red-links-tooltip branch from 48e5a4d to 76f3e74 Compare March 15, 2025 18:14
@janezd janezd marked this pull request as ready for review March 15, 2025 18:17
@janezd
Copy link
Contributor Author

janezd commented Mar 15, 2025

  • Now the tooltip changes if the user edits widget titles.
  • It is still assumed that disabled dynamic link is due to invalid signal type. I won't dug into this.
  • Existing tests needed to be fixed because the anchor now needs a widget (to get its title). I also test the tooltip.

@ales-erjavec, please review and merge if it's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants