Skip to content

[FIX] Network file: Output valid table when file with data does not match#185

Merged
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:nxfile-labels-to-table
Feb 3, 2021
Merged

[FIX] Network file: Output valid table when file with data does not match#185
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:nxfile-labels-to-table

Conversation

@janezd
Copy link
Copy Markdown
Contributor

@janezd janezd commented Jan 29, 2021

Issue

Fixes #160.

Description of changes

When data table exists, but its length does not match the number of vertices, it was not used, but the node labels were not converted from ndarray to Table.

Because of mis-indented break. :)

Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the nxfile-labels-to-table branch from afafc4e to 08a07bd Compare January 29, 2021 17:59
@ajdapretnar ajdapretnar merged commit 48774b4 into biolab:master Feb 3, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.48%. Comparing base (247b3d8) to head (08a07bd).
⚠️ Report is 176 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   75.23%   75.48%   +0.25%     
==========================================
  Files          21       21              
  Lines        2790     2790              
==========================================
+ Hits         2099     2106       +7     
+ Misses        691      684       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network File outputs invalid Table

3 participants