[FIX] Network file: Output valid table when file with data does not match

orangecontrib/network/widgets/OWNxFile.py

@@ -211,7 +211,7 @@ def set_network_nodes(self):
                     if info_msg is not None:
                         info_msg()
                     self.network.nodes = self._combined_data(data_source)
-                break
+                    break
         else:
             self.network.nodes = self._label_to_tabel()
             self.Information.suggest_annotation()

orangecontrib/network/widgets/tests/networks/test_inv.net

@@ -0,0 +1,19 @@
+*network NetworkX
+*vertices 7
+1 aa 0.0 0.0
+2 bb 0.0 0.0
+3 cc 0.0 0.0
+4 dd 0.0 0.0
+5 ee 0.0 0.0
+6 ff 0.0 0.0
+7 gg 0.0 0.0
+*edges
+1 2 1.0
+1 3 2.0
+2 6 3.0
+2 4 4.0
+4 3 5.0
+4 5 6.0
+4 6 7.0
+6 1 8.0
+7 5 9.0

orangecontrib/network/widgets/tests/networks/test_inv.tab

@@ -0,0 +1,7 @@
+name	department
+string	d
+
+aaa	a
+bbb	a
+ccc	b
+ddd	b

orangecontrib/network/widgets/tests/test_OWNxFile.py

@@ -1,9 +1,14 @@
+import os
 import unittest
 from unittest.mock import patch, Mock
 
 from orangecontrib.network.widgets.OWNxFile import OWNxFile
 from orangecontrib.network.widgets.tests.utils import NetworkTest
 
+TEST_NETS = os.path.join(os.path.split(__file__)[0], "networks")
+
+def _get_test_net(filename):
+    return os.path.join(TEST_NETS, filename)
 
 class TestOWNxFile(NetworkTest):
     def setUp(self):
@@ -18,6 +23,24 @@ def test_read_error(self):
         self.widget.open_net_file(filename)
         self.assertFalse(self.widget.Error.io_error.is_shown())
 
+    def test_load_datafile(self):
+        self.widget.open_net_file(_get_test_net("test.net"))
+        items = self.get_output(self.widget.Outputs.items)
+        self.assertEqual(items[0]["name"], "aaa")
+
+    def test_invalid_datafile_length(self):
+        # When data file's length does not match, the widget must create
+        # a table from node labels
+        self.widget.open_net_file(_get_test_net("test_inv.net"))
+        self.assertTrue(self.widget.Warning.auto_mismatched_lengths)
+
+        network = self.get_output(self.widget.Outputs.network)
+        self.assertEqual(network.number_of_nodes(), 7)
+
+        items = self.get_output(self.widget.Outputs.items)
+        self.assertEqual(len(items), 7)
+        self.assertEqual(items[0]["node_label"], "aa")
+
 
 if __name__ == "__main__":
     unittest.main()