Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a redundant web view #464

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Remove a redundant web view #464

merged 1 commit into from
Oct 17, 2019

Conversation

puripant
Copy link

Issue

Partially fix #204

Description of changes

I remove one _new_webview() out of _create_layout().

From my understanding, handleNewSignals() calls either _apply_topic(), _apply_corpus(), or clear(). The latter directly calls _new_webview() while the first two call _repopulate_wordcloud() and then on_cloud_pref_change() which calls _new_webview() in the end. So, calling _new_webview() in _create_layout() is unnecessary and actually redundant.

Includes
  • Code changes
  • Tests
  • Documentation

To remove the white line according to issue #204
@codecov-io
Copy link

Codecov Report

Merging #464 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   85.88%   85.88%           
=======================================
  Files          34       34           
  Lines        1927     1927           
  Branches      329      329           
=======================================
  Hits         1655     1655           
  Misses        232      232           
  Partials       40       40

@ajdapretnar
Copy link
Collaborator

Real nice! Thank you! ⭐️

@ajdapretnar ajdapretnar merged commit 4751347 into biolab:master Oct 17, 2019
@puripant puripant deleted the patch-1 branch October 19, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word Cloud: annoying white line at the top
3 participants