Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Partially fix #204
Description of changes
I remove one
_new_webview()
out of_create_layout()
.From my understanding,
handleNewSignals()
calls either_apply_topic()
,_apply_corpus()
, orclear()
. The latter directly calls_new_webview()
while the first two call_repopulate_wordcloud()
and thenon_cloud_pref_change()
which calls_new_webview()
in the end. So, calling_new_webview()
in_create_layout()
is unnecessary and actually redundant.Includes