fix(lint): useArrowFunction should parenthesise the expr starting with {

[siketyan]

Summary

Closes #4967

In ECMAScript, the return value of an arrow expression that starts with { needs to be parenthesised to be a valid expression, even if the expression is not a JsObjectExpression. This pull request fixes the condition to parenthesise the expression or not.

Test Plan

Snapshot tests added.

[codspeed-hq]

CodSpeed Performance Report

Merging #5170 will not alter performance

_{Comparing siketyan:fix/GH-4967 (0d9cda7) with main (d739883)}

Summary

✅ 94 untouched benchmarks

[ematipico]

We have a trait that checks if the expression needs parentheses: https://github.com/biomejs/biome/blob/main/crates%2Fbiome_js_syntax%2Fsrc%2Fparentheses%2Fmod.rs#L53

The trait should be implemented for the nodes you're working with. If not, it should be implemented

[siketyan]

@ematipico I looked up NeedsParentheses impls and there is no impl for the arrow function body. I added impl for AnyJsFunctionBody but I am not sure it is the right place.

Plus, I tried to replace the existing needs_parentheses implementation within the module. However, the NeedsParentheses trait needs to the AST node to be placed under some parent, which is difficult in this situation. Any idea to determine whether a node A needs parens to be placed in node B? We know what is the parent node here from function_expression.parent(), but we need to construct a new tree that includes the converted arrow function to use NeedsParentheses.