-
-
Notifications
You must be signed in to change notification settings - Fork 16
New source: SILVA taxonomy #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jplfaria
wants to merge
18
commits into
biopragmatics:main
Choose a base branch
from
jplfaria:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d267ea4
adding module for silva taxonomy
jplfaria 205fad3
Run ruff
cthoyt b99644a
Update silva.py
cthoyt 9ff0766
Merge branch 'main' into pr/348
cthoyt a159f4a
Add typedef example
cthoyt 09a07e9
Update silva.py
cthoyt 68ca239
Update __init__.py
cthoyt b4fa6e3
Replace parent relationship with HAS_TAXONOMIC_CLASSIFICATION typedef
jplfaria 8967240
Update silva.py
cthoyt 7926155
Merge branch 'main' into pr/348
cthoyt f4b2619
ID spaces get automatically constructed now
cthoyt 20acf22
Fix nomenclature mistake
cthoyt f46273a
Add fixmes
cthoyt 1fffd60
Update silva.py
cthoyt 25e44d6
Update silva.py
cthoyt ae99167
Remove duplicates
cthoyt 151d147
Minor cleanup
cthoyt 5381ec3
Update silva.py
cthoyt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,160 @@ | ||
"""Convert SILVA small subunit (ssu) taxonomy to OBO format.""" | ||
|
||
import logging | ||
from collections.abc import Iterable | ||
|
||
import pandas as pd | ||
from tqdm.auto import tqdm | ||
|
||
from pyobo.struct import Obo, Reference, Term, TypeDef, default_reference | ||
from pyobo.struct.typedef import has_taxonomy_rank | ||
from pyobo.utils.path import ensure_path | ||
|
||
__all__ = [ | ||
"SILVAGetter", | ||
] | ||
|
||
PREFIX = "silva.taxon" | ||
|
||
#: A mapping from SILVA rank names to TAXRANK references | ||
SILVA_RANK_TO_TAXRANK = { | ||
"domain": Reference(prefix="TAXRANK", identifier="0000037", name="domain"), | ||
"major_clade": Reference(prefix="TAXRANK", identifier="0001004", name="major_clade"), | ||
"superkingdom": Reference(prefix="TAXRANK", identifier="0000022", name="superkingdom"), | ||
"kingdom": Reference(prefix="TAXRANK", identifier="0000017", name="kingdom"), | ||
"subkingdom": Reference(prefix="TAXRANK", identifier="0000029", name="subkingdom"), | ||
"superphylum": Reference(prefix="TAXRANK", identifier="0000027", name="superphylum"), | ||
"phylum": Reference(prefix="TAXRANK", identifier="0000001", name="phylum"), | ||
"subphylum": Reference(prefix="TAXRANK", identifier="0000008", name="subphylum"), | ||
"infraphylum": Reference(prefix="TAXRANK", identifier="0000040", name="infraphylum"), | ||
"superclass": Reference(prefix="TAXRANK", identifier="0000015", name="superclass"), | ||
"class": Reference(prefix="TAXRANK", identifier="0000002", name="class"), | ||
"subclass": Reference(prefix="TAXRANK", identifier="0000007", name="subclass"), | ||
"infraclass": Reference(prefix="TAXRANK", identifier="0000019", name="infraclass"), | ||
"superorder": Reference(prefix="TAXRANK", identifier="0000020", name="superorder"), | ||
"order": Reference(prefix="TAXRANK", identifier="0000003", name="order"), | ||
"suborder": Reference(prefix="TAXRANK", identifier="0000014", name="suborder"), | ||
"superfamily": Reference(prefix="TAXRANK", identifier="0000018", name="superfamily"), | ||
"family": Reference(prefix="TAXRANK", identifier="0000004", name="family"), | ||
"subfamily": Reference(prefix="TAXRANK", identifier="0000024", name="subfamily"), | ||
"genus": Reference(prefix="TAXRANK", identifier="0000005", name="genus"), | ||
} | ||
|
||
#: URLs for the SILVA files. | ||
SILVA_TAXONOMY_URL = "https://www.arb-silva.de/fileadmin/silva_databases/current/Exports/taxonomy/tax_slv_ssu_138.2.txt.gz" | ||
SILVA_TAXMAP_URL = "https://www.arb-silva.de/fileadmin/silva_databases/current/Exports/taxonomy/taxmap_slv_ssu_ref_nr_138.2.txt.gz" | ||
|
||
logger = logging.getLogger(__name__) | ||
logger.setLevel(logging.WARNING) | ||
|
||
RELATION_NEEDS_NEW_NAME = TypeDef( | ||
reference=default_reference(PREFIX, "has_related_sequence", name="has related sequence"), | ||
# FIXME! | ||
definition="This relation represents a connection between a species and ENA records that are " | ||
"annotated by SILVA's 'taxmap' that these are related in some way. It's crucial to make more explicit " | ||
"what this relation is. Old text: Indicates that the genome sequence represented by an ENA accession is " | ||
"classified under this taxon by SILVA.", | ||
is_metadata_tag=True, | ||
) | ||
|
||
|
||
class SILVAGetter(Obo): | ||
"""An ontology representation of the SILVA taxonomy.""" | ||
|
||
ontology = bioversions_key = PREFIX | ||
typedefs = [has_taxonomy_rank, RELATION_NEEDS_NEW_NAME] | ||
root_terms = [ | ||
Reference(prefix=PREFIX, identifier="2", name="Archaea"), | ||
Reference(prefix=PREFIX, identifier="3", name="Bacteria"), | ||
Reference(prefix=PREFIX, identifier="4", name="Eukaryota"), | ||
] | ||
|
||
def iter_terms(self, force: bool = False) -> Iterable[Term]: | ||
"""Iterate over terms in the SILVA ontology.""" | ||
return iter_terms_silva(version=self._version_or_raise, force=force) | ||
|
||
|
||
def iter_terms_silva(version: str, force: bool = False) -> Iterable[Term]: | ||
"""Iterate over SILVA terms from the main taxonomy and taxmap files.""" | ||
# --- Process the main taxonomy file --- | ||
taxonomy_path = ensure_path(PREFIX, url=SILVA_TAXONOMY_URL, version=version, force=force) | ||
tax_df = pd.read_csv( | ||
taxonomy_path, | ||
sep="\t", | ||
header=None, | ||
names=["taxonomy", "taxon_id", "rank", "ignore", "introduced"], | ||
dtype=str, | ||
) | ||
tax_df.fillna("", inplace=True) | ||
|
||
#: a dictionary that maps the joined taxonomy path (with trailing ";") to taxon_id | ||
tax_path_to_id: dict[str, str] = {} | ||
|
||
#: maps taxon_id to the Term object | ||
silva_taxon_id_to_term: dict[str, Term] = {} | ||
|
||
for idx, row in tqdm( | ||
tax_df.iterrows(), | ||
total=len(tax_df), | ||
desc=f"[{PREFIX}] processing main taxonomy", | ||
unit_scale=True, | ||
): | ||
tax_str = row["taxonomy"].strip() | ||
silva_taxon_id = row["taxon_id"].strip() | ||
rank_raw = row["rank"].strip() | ||
rank = rank_raw.lower() | ||
# Split taxonomy string by ";" and discard empty parts. | ||
parts = [p.strip() for p in tax_str.split(";") if p.strip()] | ||
if not parts: | ||
logger.warning(f"Row {idx}: empty taxonomy string: {tax_str}") | ||
continue | ||
|
||
# The term's name is the last element (e.g. for "Bacteria;Actinomycetota;", name is "Actinomycetota"). | ||
name = parts[-1] | ||
term = Term(reference=Reference(prefix=PREFIX, identifier=silva_taxon_id, name=name)) | ||
if rank in SILVA_RANK_TO_TAXRANK: | ||
term.annotate_object(has_taxonomy_rank, SILVA_RANK_TO_TAXRANK[rank]) | ||
else: | ||
logger.warning( | ||
f"Row {idx}: unknown rank '{rank_raw}' for taxonomy: {tax_str} (taxon id: {silva_taxon_id})" | ||
) | ||
|
||
# Determine the parent by joining all but the last element. | ||
if len(parts) > 1: | ||
parent_key = ";".join(parts[:-1]) + ";" # e.g. "Bacteria;" | ||
parent_id = tax_path_to_id.get(parent_key) | ||
if parent_id: | ||
# TODO get parent's name in there if possible, makes the OBO file much more readable | ||
term.append_parent(Reference(prefix=PREFIX, identifier=parent_id)) | ||
full_key = ";".join(parts) + ";" | ||
tax_path_to_id[full_key] = silva_taxon_id | ||
silva_taxon_id_to_term[silva_taxon_id] = term | ||
|
||
# --- Process the taxmap file --- | ||
# This file has a header with columns: primaryAccession, start, stop, path, organism_name, taxid | ||
taxmap_path = ensure_path(PREFIX, url=SILVA_TAXMAP_URL, version=version, force=force) | ||
taxmap_df = pd.read_csv(taxmap_path, sep="\t", dtype=str, usecols=[0, 5]) | ||
|
||
for ena_embl_id, species_silva_taxon_id in tqdm( | ||
taxmap_df.values, desc=f"[{PREFIX}] processing taxmap", unit_scale=True | ||
): | ||
if pd.isna(ena_embl_id) or pd.isna(species_silva_taxon_id): | ||
continue | ||
# FIXME please add a comment on why we're only doing this based on the species ID. | ||
# does SILVA not make mappings for other ranks? | ||
term = silva_taxon_id_to_term.get(species_silva_taxon_id) | ||
if term is None: | ||
logger.warning( | ||
f"Row {idx} in taxmap: species_taxon_id {species_silva_taxon_id} not found in main taxonomy" | ||
) | ||
else: | ||
ref = Reference(prefix="ena.embl", identifier=ena_embl_id) | ||
if ref not in term.properties[RELATION_NEEDS_NEW_NAME.reference]: | ||
term.annotate_object(RELATION_NEEDS_NEW_NAME, ref) | ||
|
||
# Yield all terms from the main taxonomy. | ||
yield from silva_taxon_id_to_term.values() | ||
|
||
|
||
if __name__ == "__main__": | ||
SILVAGetter().cli() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still need to understand the context in what it means for a SILVA taxon to be mapped to an ENA record for a sequence. I am starting to think that this is just as simple as "the sequence was derived from a sample taken from an individual of this species" but please do a deep dive to clarify further
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes look good to me.